Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fullscreen window has ~16px overscan #19038

Open
MunyuShizumi opened this issue Oct 27, 2021 · 10 comments
Open

Fullscreen window has ~16px overscan #19038

MunyuShizumi opened this issue Oct 27, 2021 · 10 comments

Comments

@MunyuShizumi
Copy link

MunyuShizumi commented Oct 27, 2021

Description

Fullscreen window introduces a 16-or-so pixel overscan on all sides, cutting off parts of the interface (ex. scroll bar in its entirety, roughly 50% of top bar). Brave's F11 fullscreen mode is not affected.

Started after package upgrade on Arch Linux today. Can't guarantee it's a Brave issue, but only Brave seems to be affected so far.

Steps to Reproduce

  1. Start Brave
  2. Make Brave window fullscreen (window itself, not Brave's F11!)

Actual result:

Outer ~16px is cropped on all sides.

brave-overscan
(Image edited: elements partially cropped horizontally to showcase interesting parts and avoid downscaling)

Expected result:

Typical Chromium-like UI, not cropped.

Reproduces how often:

Every launch so far.

Brave version (brave://version info)

Brave: 1.31.87 Chromium: 95.0.4638.54 (Official Build) (64-bit)
Revision: d31a821ec901f68d0d34ccdbaea45b4c86ce543e-refs/branch-heads/4638@{#871}
OS: Linux

Local environment info in Miscellaneous Information on bottom

Version/Channel Information:

  • Can you reproduce this issue with the current release? Yes
  • Can you reproduce this issue with the beta channel? N/A
  • Can you reproduce this issue with the nightly channel? N/A
    At work currently, will test other builds & repo later.

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? No
  • Does the issue resolve itself when disabling Brave Rewards? No
  • Is the issue reproducible on the latest version of Chrome? N/A
    At work currently, will test Chromium later.

Miscellaneous Information:

Local environment info

tl;dr: Arch Linux, Xserver, Xfce/Xfwm, stable Brave build from AUR, upgraded ~1h ago

OS: Arch Linux
Kernel: linux 5.14.14.arch1-1
Display server: xorg-server 1.20.13-2
Window manager: xfwm4 4.16.1-2
Compositor: xfwm4 4.16.1-2
Brave: (AUR) brave-bin 1:1.31.87-1

@grewscant
Copy link

grewscant commented Oct 27, 2021

Have the same issue.
OS: Debian 11
Kernel: 5.14.0-3-amd64
Brave: Version 1.31.87 Chromium: 95.0.4638.54 (Official Build) (64-bit)

@TheMenko
Copy link

TheMenko commented Nov 2, 2021

Very anoying issue.
OS: Manjaro
Kernel: 5.10.70-1-MANJARO
Brave: Version 1.32.83 Chromium: 95.0.4638.54 (Official Build) beta (64-bit)

@mesa123123
Copy link

Same Issue here
OS: Xubuntu
Brave Browser 95.1.31.88

@gitryder
Copy link

gitryder commented Nov 8, 2021

AFAIK, this is happening only on XFCE.

Also, issue is reproducible on the latest stable version of Google Chrome.

@mesa123123
Copy link

AFAIK, this is happening only on XFCE.

Also, issue is reproducible on the latest stable version of Google Chrome.

Hmm so should go to Chromium then...

@rabinadk1
Copy link

Fixed using this patch in Arch Linux: https://gitlab.xfce.org/xfce/xfwm4/-/commit/488288f6e35d5d3dc077e87fe2ed83129692f62e

@gitryder
Copy link

Fixed using this patch in Arch Linux: https://gitlab.xfce.org/xfce/xfwm4/-/commit/488288f6e35d5d3dc077e87fe2ed83129692f62e

@rabinadk1 So we just have to update xfwm, right? to what version?

@rabinadk1
Copy link

Fixed using this patch in Arch Linux: https://gitlab.xfce.org/xfce/xfwm4/-/commit/488288f6e35d5d3dc077e87fe2ed83129692f62e

@rabinadk1 So we just have to update xfwm, right? to what version?

I don't know about the version. Arch Linux has included this patch when making the package.

@addow
Copy link

addow commented Nov 15, 2021

@gitryder Patch is included since xfwm4 4.16.1-3. Patch is working for both Brave and Chromium/Google Chrome.

@grewscant
Copy link

grewscant commented Nov 16, 2021

@gitryder Patch is included since xfwm4 4.16.1-3. Patch is working for both Brave and Chromium/Google Chrome.

Ah, I'm not on Arch. On Debian 11. Will have to wait for the patch to be released, eh?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

8 participants