Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable 'RequestAdsEnabledApi' feature in Nightly #19033

Closed
aseren opened this issue Oct 27, 2021 · 6 comments
Closed

Enable 'RequestAdsEnabledApi' feature in Nightly #19033

aseren opened this issue Oct 27, 2021 · 6 comments

Comments

@aseren
Copy link

aseren commented Oct 27, 2021

Need to enable 'RequestAdsEnabledApi' on 100% in Nightly via experiments platform.

@stephendonner
Copy link

stephendonner commented Oct 28, 2021

Verified PASSED using

Brave 1.33.40 Chromium: 95.0.4638.54 (Official Build) nightly (x86_64)
Revision d31a821ec901f68d0d34ccdbaea45b4c86ce543e-refs/branch-heads/4638@{#871}
OS macOS Version 11.6.1 (Build 20G224)

Steps:

  1. new profile
  2. launched with --variations-server-url=https://variations.bravesoftware.com/seed
  3. restarted twice
  4. ensured I got the seed
  5. went to talk.brave.com
  6. clicked on the Start free 1:1 call button
  7. confirmed I got the Enable Rewards popup
example example example
Screen Shot 2021-10-28 at 9 57 00 AM Screen Shot 2021-10-28 at 9 48 08 AM Screen Shot 2021-10-28 at 9 48 18 AM

@stephendonner
Copy link

Verified PASSED on Android 9, using Brave 1.33.40, Chromium 95.0.4638.54, on a Google Pixel XL.

Steps:

  1. wrote out a variations file using stephendonner@Stephens-MBP platform-tools % adb shell "echo 'https://variations.bravesoftware.com/seed' > /data/local/tmp/brave-test-variations-server-url"
  2. installed build
  3. launched Brave
  4. restarted twice
  5. confirmed RequestAdsEnabledApiStudy:Enabled appears in brave://version
  6. loaded talk.brave.com
  7. confirmed there's now a Start a free 1:1 call button
  8. tapped on it
  9. confirmed I got the Turn on Brave Rewards doorhanger
  10. tapped to confirm
  11. confirmed my Brave Talk call started
example example example example
Screenshot_20211028-111357 Screenshot_20211028-111550 Screenshot_20211028-111600 Screenshot_20211028-111603

@kjozwiak
Copy link
Member

Closing as this was merged into production via brave/brave-variations#152 (review). Thanks for all the hard wok getting this checked/out the door @stephendonner 👍

@kjozwiak
Copy link
Member

@stephendonner moved this into the 1.33.x milestone as this was pushed into Nightly but added the QA/No & release-notes/exclude labels so it doesn't get picked up later by @brave/legacy_qa when we start verifying issues within 1.33.x.

@stephendonner
Copy link

@kjozwiak thanks; next time, I should put nightly notes in brave/brave-variations#151 as would for other PRs, correct?

@kjozwiak
Copy link
Member

yup 👍 Usually we don't open tickets like we did for this one so no worries. But we usually put all the QA notes in the main (staging) PR so if we ever need to go back and look at what was checked, we could always check the PRs that were merged into main and see what QA/verifications were done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants