Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Follow up of #15906 - Implement 1p Ephemeral Storage Functionality (functionality) #19006

Closed
GeetaSarvadnya opened this issue Oct 26, 2021 · 4 comments

Comments

@GeetaSarvadnya
Copy link

Description

Follow up of #15906 - Implement 1p Ephemeral Storage Functionality (functionality)

Steps to Reproduce

  1. new profile
  2. launch Brave
  3. added [*.]yandex.com to Always clear cookies when windows are closed, in brave://settings/cookies
  4. loaded yandex.com/internet in 5 new tabs
  5. noted the value for yandexuid was 9823635641635263673, across all 5 tabs
  6. closed all tabs (but NOT the browser)
  7. loaded yandex.com/internet again in a single tab
  8. noted the value for yandexuid is still same 9823635641635263673

Actual result:

value for yandexuid is same is step 5 and step 8

Expected result:

value for yandexuid should be different in step 5 and step 8

Reproduces how often:

Easy

Brave version (brave://version info)

Brave 1.32.82 Chromium: 95.0.4638.54 (Official Build) dev (64-bit)
Revision d31a821ec901f68d0d34ccdbaea45b4c86ce543e-refs/branch-heads/4638@{#871}
OS Windows 10 Version 21H1 (Build 19043.1288)

Version/Channel Information:

  • Can you reproduce this issue with the current release?
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Miscellaneous Information:

cc: @brave/legacy_qa @goodov

@GeetaSarvadnya
Copy link
Author

Looks like windows specific issue as it worked for @stephendonner on both macOS and Linux. @stephendonner Could you please test this issue on your windows machine?

@GeetaSarvadnya
Copy link
Author

I am getting the same result with/without enabling 1p flag via brave://flags.

@stephendonner
Copy link

stephendonner commented Oct 26, 2021

@GeetaSarvadnya sorry, the flag is actually #brave-first-party-ephemeral-storage (NOT 1p); when I set that (sorry for omitting that from my verification steps!), open 5 tabs with yandex.com/internet, note the yandexid (they are all the same) and then close the last yandex.com/internet tab, and open a new one -- same browser session -- I get a new yandexid.

@GeetaSarvadnya
Copy link
Author

Works as expected hence closing the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants