Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Youtube videos with custom paths should show in Rewards panel correctly #1886

Closed
jasonrsadler opened this issue Oct 29, 2018 · 4 comments · Fixed by brave/brave-core#1703
Closed

Comments

@jasonrsadler
Copy link

Description

When navigating to a youtube channel with a custom path, youtube is shown as the publisher in panel instead of the actual publisher

Steps to Reproduce

  1. Navigate to https://www.youtube.com/bravesoftware
  2. Open Rewards panel

Actual result:

Publisher is listed as YouTube

Expected result:

Publisher should be listed as Brave or any other publisher that corresponds to a custom path.

Reproduces how often:

always

Brave version (brave://version info)

Brave 0.58.1 Chromium: 70.0.3538.77 (Developer Build) (64-bit)
Revision 0f6ce0b0cd63a12cb4eccea3637b1bc9a29148d9-refs/branch-heads/3538@{#1039}
OS Mac OS X

Reproducible on current release:

  • Does it reproduce on brave-browser dev/beta builds?
    Yes

Website problems only:

  • Does the issue resolve itself when disabling Brave Shields? N/A
  • Is the issue reproducible on the latest version of Chrome? N/A

Additional Information

@NejcZdovc NejcZdovc added this to the 0.58.x - Nightly milestone Oct 29, 2018
@rebron rebron removed this from the 0.58.x - Nightly milestone Oct 30, 2018
@bbondy bbondy added this to the 1.x Backlog milestone Oct 30, 2018
@NejcZdovc NejcZdovc added the priority/P4 Planned work. We expect to get to it "soon". label Oct 31, 2018
@NejcZdovc NejcZdovc self-assigned this Dec 3, 2018
@NejcZdovc NejcZdovc assigned jasonrsadler and unassigned NejcZdovc Dec 3, 2018
@jonathansampson
Copy link
Contributor

Glad to see this has been captured; I've noticed it off and on and assumed it was some transient issue with state. Glad to see it is already well understood!

@NejcZdovc NejcZdovc added priority/P3 The next thing for us to work on. It'll ride the trains. and removed priority/P4 Planned work. We expect to get to it "soon". labels Dec 24, 2018
@NejcZdovc
Copy link
Contributor

+1 from #2732

@NejcZdovc NejcZdovc added priority/P2 A bad problem. We might uplift this to the next planned release. and removed priority/P3 The next thing for us to work on. It'll ride the trains. labels Jan 21, 2019
@rebron rebron modified the milestone: 1.x Backlog Feb 7, 2019
@kjozwiak
Copy link
Member

kjozwiak commented Mar 7, 2019

@brave/legacy_qa now that brave/brave-core#1867 has landed, we'll need to go through this issue with the latest 0.62.x build and verify that it's working and didn't cause any other obvious regressions. If things are looking good, we'll uplift to 0.61.x as per the discussion on the b-c triage meeting earlier in the week.

@kjozwiak
Copy link
Member

kjozwiak commented Mar 7, 2019

Verification PASSED on macOS 10.14.3 x64 using the following build:

Brave 0.62.24 Chromium: 73.0.3683.56 (Official Build) dev(64-bit)
Revision 303af44e2f2948869279f120021c778855d76ead-refs/branch-heads/3683@{#653}
OS Mac OS X

Verification passed on

Brave 0.62.24 Chromium: 73.0.3683.56 (Official Build) dev(64-bit)
Revision 303af44e2f2948869279f120021c778855d76ead-refs/branch-heads/3683@{#653}
OS Linux

Verification passed on

Brave 0.62.24 Chromium: 73.0.3683.56 (Official Build) dev (64-bit)
Revision 303af44e2f2948869279f120021c778855d76ead-refs/branch-heads/3683@{#653}
OS Windows 10 OS Build 17134.523

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants