Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adaptive captcha Brave Ads paused modal is shown when browser window is minimized #18857

Open
btlechowski opened this issue Oct 19, 2021 · 2 comments

Comments

@btlechowski
Copy link

Follow up to #15600

Steps to Reproduce

  1. Clean profile
  2. Run Brave
  3. Enable Rewards and Ads
  4. Schedule a captcha for your payment ID
  5. Trigger unblinded tokens refill
  6. Minimize Brave

Actual result:

Adaptive captcha Brave Ads paused modal stays visible
image

Expected result:

Adaptive captcha Brave Ads paused modal is hidden along with the browser window.

Reproduces how often:

Easily reproduced

Brave version (brave://version info)

Brave 1.31.85 Chromium: 95.0.4638.50 (Official Build) (64-bit)
Revision 3e9db37693d0cf8e31a89fbcf50401ae91125cef-refs/branch-heads/4638@{#816}
OS Ubuntu 18.04 LTS

cc @emerick @tmancey @jsecretan @brave/legacy_qa @rebron

@emerick
Copy link
Contributor

emerick commented Oct 19, 2021

You could have multiple browser windows open, so this might get a little bit complicated. Do we implement something similar with ads notifications?

@tmancey
Copy link
Contributor

tmancey commented Oct 20, 2021

Multiple profiles should not show multiple ads. However, the solution would not work in this case. @jsecretan we should consider limiting rewards/ads to the users main profile. Your thoughts?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants