Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adaptive captcha missing translation when resolving captcha #18856

Open
btlechowski opened this issue Oct 19, 2021 · 2 comments
Open

Adaptive captcha missing translation when resolving captcha #18856

btlechowski opened this issue Oct 19, 2021 · 2 comments
Labels
feature/ads l10n OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA/Test-Plan-Specified QA/Yes

Comments

@btlechowski
Copy link

btlechowski commented Oct 19, 2021

Follow up to #15600

Steps to Reproduce

  1. Clean profile
  2. Run Brave in Polish PL locale
  3. Enable Rewards and Ads
  4. Schedule a captcha for your payment ID
  5. Trigger unblinded tokens refill
  6. Click Rozwiąż

Actual result:

Missing translations
image
image

Expected result:

No missing translations

Reproduces how often:

Easily reproduced

Brave version (brave://version info)

Brave 1.31.85 Chromium: 95.0.4638.50 (Official Build) (64-bit)
Revision 3e9db37693d0cf8e31a89fbcf50401ae91125cef-refs/branch-heads/4638@{#816}
OS Ubuntu 18.04 LTS

cc @emerick @tmancey @jsecretan @brave/legacy_qa @rebron @mkarolin

@rebron rebron added the priority/P2 A bad problem. We might uplift this to the next planned release. label Oct 19, 2021
@emerick
Copy link
Contributor

emerick commented Oct 19, 2021

@gpestana I think this would be implemented server-side, right?

@gpestana
Copy link

gpestana commented Oct 19, 2021

Correct, the locale logic is implemented on the server side since the iframe payload generated on the server. We don't have the locale logic implemented yet, although it is top priority work once we roll out adaptive captchas to production.

Related to https://github.com/brave-intl/bat-reputation/issues/52

@zenparsing zenparsing added priority/P3 The next thing for us to work on. It'll ride the trains. and removed priority/P2 A bad problem. We might uplift this to the next planned release. labels Oct 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/ads l10n OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA/Test-Plan-Specified QA/Yes
Projects
None yet
Development

No branches or pull requests

5 participants