Can't dismiss grant notification

[emerick]

@bbondy noticed that he can't dismiss grant notifications on the latest release / test channel. His grant was made on 10/23/2018, which means it's using the old version of the notification ID which had a prepended "n". We'll need to support dismissing notifications formatted like this, for backwards compatability purposes.

[kjozwiak]

Ran into the same issue after updating to 0.57.3 Chromium: 70.0.3538.67 (Official Build) dev. @tomlowenthal has also ran into this in the past. @emerick I don't have exact STR, but I have a profile that I can send you that has the issue. I have 13 notifications but can't dismiss any of them by clicking on "OK".

[LaurenWags]

Verified passed with

Brave	0.56.8 Chromium: 70.0.3538.77 (Official Build) (64-bit)
Revision	0f6ce0b0cd63a12cb4eccea3637b1bc9a29148d9-refs/branch-heads/3538@{#1039}
OS	Mac OS X

• Verified test plan in Can't dismiss grant notification brave-core#755 but also cc-ing @kjozwiak to try with the profile he has as well.

Verification Passed on

Brave	0.56.8 Chromium: 70.0.3538.77 (Official Build) (64-bit)
Revision	0f6ce0b0cd63a12cb4eccea3637b1bc9a29148d9-refs/branch-heads/3538@{#1039}
OS	Linux

Went through verification using the following build under macOS 10.14 x64 - PASSED

Brave	0.56.9 Chromium: 70.0.3538.77 (Official Build) (64-bit)
Revision	0f6ce0b0cd63a12cb4eccea3637b1bc9a29148d9-refs/branch-heads/3538@{#1039}
OS	Mac OS X

• installed 0.55.20, stacked 15 notifications, updated to 0.56.9 and dismissed the notifications
• installed 0.55.22, stacked 15 notifications, updated to 0.56.9 and dismissed the notifications

Verified passed with

Brave	0.56.10 Chromium: 70.0.3538.77 (Official Build) (64-bit)
Revision	0f6ce0b0cd63a12cb4eccea3637b1bc9a29148d9-refs/branch-heads/3538@{#1039}
OS	Mac OS X

• installed 0.55.20, stacked 15 notifications, updated to 0.56.10 and dismissed the notifications
• installed 0.55.22, stacked 15 notifications, updated to 0.56.10 and dismissed the notifications

Went through verification using the following build under macOS 10.14 x64 - PASSED

Brave	0.56.10 Chromium: 70.0.3538.77 (Official Build) (64-bit)
Revision	0f6ce0b0cd63a12cb4eccea3637b1bc9a29148d9-refs/branch-heads/3538@{#1039}
OS	Mac OS X

• stacked 20 notifications using 0.55.20, updated to 0.56.10 and ensured that you could dismiss the notifications
• stacked 20 notifications using 0.55.22, updated to 0.56.10 and ensured that you could dismiss the notifications
• ensured that you can dismiss "brave":{"rewards":{"notifications":"[{\"args\":[],\"id\":\"0\",\"timestamp\":1541706932,\"type\":2}
• ensured that you can dismiss "brave":{"rewards":{"notifications":"[{\"args\":[],\"id\":0,\"timestamp\":1541707248,\"type\":2}]"}

Verification passed on Windows 7 x64

Brave	0.56.10 Chromium: 70.0.3538.77 (Official Build) (64-bit)
Revision	0f6ce0b0cd63a12cb4eccea3637b1bc9a29148d9-refs/branch-heads/3538@{#1039}
OS	Windows 7 x64

Updated from 0.55.22 to 0.56.10 by using test stub installers.
Also tested "id": "0" and "id": 0 scenarios.

[GeetaSarvadnya]

As per the test plan mentioned in #755 PR, we need to upgrade the profile in order to dismiss/remove the grant notification. As per my knowledge, we will not be able to test this defect on Windows as we don't have offline installer and don't have option to install older version and upgrade it to the latest version.
@kjozwiak Please suggest if there are any ways i can test this defect on windows.

[kjozwiak]

@emerick running through brave/brave-core#755 and brave/brave-core#812 works fine but I have a profile that's affected by this and I still can't dismiss the notifications by clicking on OK. I do move the profile around between dev, beta and release so it's entirely possible that I might have bricked it into an unrecoverable state.

I can provide you with the profile if you want to take a look and see what's happening. Or I can send over the Preferences file of the affected profile.

Results:

• 0.56.9 Chromium: 70.0.3538.77 - can't dismiss the 13 notifications
• 0.56.8 Chromium: 70.0.3538.77 - can't dismiss the 13 notifications

[emerick]

@kjozwiak Yes, please provide the profile. Also, if you could tell me what the brave.rewards.notifications key looks like in the profile's Preferences file that would be great.

[kjozwiak]

@emerick it looks like this:

"brave":{"rewards":{"notifications":"[{\"args\":[],\"id\":\"0\",\"timestamp\":1540535645,\"type\":2},{\"args\":[],\"id\":\"rewards_notification_grant\",\"timestamp\":1541471477,\"type\":2}]"}

I'll send you the profile in a DM on Slack 👍

[emerick]

@kjozwiak OK, it's the invalid ID issue again. Apparently it can show up as a 0 (integer) or as "0" (string); we'll need to handle both cases.

[kjozwiak]

This is going to be really hard to test on Windows due to not having the capability of downloading 0.55.20 as we don't have offline installers yet. The sub installers are pointing to the latest released version and the custom stub installers on the test channel are pointing to 0.56.10 (RC2). Going to ping DevOps and see if we can get offline installers for 0.55.20.

[kjozwiak]

Will keep #2004 in the release notes as they're basically the same issues fixing the same problem.