Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Occasional renderer crash on WASM load/compilation step #18562

Closed
goodov opened this issue Oct 5, 2021 · 1 comment · Fixed by brave/brave-core#10366
Closed

Occasional renderer crash on WASM load/compilation step #18562

goodov opened this issue Oct 5, 2021 · 1 comment · Fixed by brave/brave-core#10366
Assignees
Labels

Comments

@goodov
Copy link
Member

goodov commented Oct 5, 2021

After migration to 94.0.4606.50 we experience WASM-related hangs and crashes (reported in Slack).

image

Looking at Chromium version and v8 version, we can see that some problem existed in the code and was fixed recently.
https://omahaproxy.appspot.com/v8.json?version=94.0.4606.50
https://chromium.googlesource.com/v8/v8.git/+/refs/heads/9.4.146/src/wasm/module-compiler.cc#3060
https://chromium-review.googlesource.com/c/v8/v8/+/3172761

We need to apply a manual patch to fix this in 1.30.x and maybe in the next version.
The fix should appear in Chromium 96.0.4650.0. So we must apply this patch in all releases where Chromium < 96.0.4650.0

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Oct 11, 2021

Verification passed on

Brave | 1.30.89 Chromium: 94.0.4606.81 (Official Build) (64-bit)
-- | --
Revision | 5a03c5f1033171d5ee1671d219a59e29cf75e054-refs/branch-heads/4606@{#1320}
OS | Windows 10 Version 21H1 (Build 19043.1266)

Steps:

  1. new profile
  2. launch Brave
  3. load talk.brave.com
  4. enable Rewards via the BAT icon
  5. click on the Start free 1:1 call button
  6. next, did various reload, Back navigation, and interrupt scenarios, to try to get it to trigger
  • Confirmed after 20+ tries that I can no longer reproduce the crash issue.

Verified passed with

Brave | 1.30.89 Chromium: 94.0.4606.81 (Official Build) (x86_64)
-- | --
Revision | 5a03c5f1033171d5ee1671d219a59e29cf75e054-refs/branch-heads/4606@{#1320}
OS | macOS Version 10.15.7 (Build 19H1417)

Verified STR from brave/brave-core#10366 (comment)
Ran through steps multiple (~20) times, confirmed no crash observed.


Verification passed on

Brave 1.30.89 Chromium: 94.0.4606.81 (Official Build) (64-bit)
Revision 5a03c5f1033171d5ee1671d219a59e29cf75e054-refs/branch-heads/4606@{#1320}
OS Ubuntu 18.04 LTS

Verified STR from brave/brave-core#10366 (comment)
Ran through steps multiple (~20) times, confirmed no crash observed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants