-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Brave ads dev environment #17812
Labels
dev-concern
feature/ads
OS/Android
Fixes related to Android browser functionality
OS/Desktop
priority/P4
Planned work. We expect to get to it "soon".
QA Pass - Android ARM
QA Pass - Android Tab
QA Pass-macOS
QA/Yes
release-notes/exclude
Milestone
Comments
24 tasks
Verified
|
Brave | 1.31.66 Chromium: 94.0.4606.61 (Official Build) beta (x86_64) |
---|---|
Revision | 418b78f5838ed0b1c69bb4e51ea0252171854915-refs/branch-heads/4606@{#1204} |
OS | macOS Version 11.6 (Build 20G165) |
Staging (--brave-ads-staging --rewards=staging=true
)
Steps:
- new profile
- launched Brave
--enable-logging=stderr --vmodule="*/variations/*"=6,"*/bat-native-ledger/*"=6,"*/brave_rewards/*"=6,"*/bat-native-ads/*"=6,"*/bat-native-confirmations/*"=6,"*/brave_ads/*"=9,"*/brave_user_model/*"=6 --brave-ads-staging --brave-ads-debug --rewards=staging=true,reconcile-interval=3
- open a new-tab page
- click the
Start using Rewards
button - scrolled down on the new-tab page
- clicked on
Show Brave News
- scrolled down to find an inline-content ad
- viewed the ad
- opened
brave://rewards
and the new-tab page - confirmed I was paid for viewing the ad
- waited
- resumed activity on computer after some time
- viewed system-notification ad
- confirmed via the NTP and
brave://rewards
I was rewarded for viewing it - viewed a promoted-content ad in Brave News
- confirmed via the NTP and
brave://rewards
I was rewarded for viewing it - viewed a NTP sponsored image, but wasn't rewarded for it
Production
Steps:
- new profile
- launched Brave
--enable-logging=stderr --vmodule="*/variations/*"=6,"*/bat-native-ledger/*"=6,"*/brave_rewards/*"=6,"*/bat-native-ads/*"=6,"*/bat-native-confirmations/*"=6,"*/brave_ads/*"=9,"*/brave_user_model/*"=6
- opened a new-tab page with a sponsored image
- confirmed I was paid for viewing the ad
- waited a while
- started typing
- viewed a system-notification ad
- confirmed I was paid for viewing the ad
- opened a new-tab page
- viewed a sponsored-image ad, but wasn't rewarded
- wasn't able to view any inline-content ads
- viewed a promoted-content ad, but wasn't rewarded for it
Development (--rewards=development=true
)
- new profile
- launched Brave using
--enable-logging=stderr --vmodule="*/variations/*"=6,"*/bat-native-ledger/*"=6,"*/brave_rewards/*"=6,"*/bat-native-ads/*"=6,"*/bat-native-confirmations/*"=6,"*/brave_ads/*"=9,"*/brave_user_model/*"=6 --brave-ads-debug --brave-ads-development --rewards=development=true
Got development
endpoints:
> Url: https://api.rewards.brave.software/v1/parameters
, which returned 20x
responses.
Chasing this last issue up with @tmancey and will file a spinoff bug if needed.
Verification passed on Oppo Reno 5 with Android 11 running 1.31.86 x64 build
Verification passed on Samsung Tab A with Android 10 running 1.31.86 x64 build
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
dev-concern
feature/ads
OS/Android
Fixes related to Android browser functionality
OS/Desktop
priority/P4
Planned work. We expect to get to it "soon".
QA Pass - Android ARM
QA Pass - Android Tab
QA Pass-macOS
QA/Yes
release-notes/exclude
No description provided.
The text was updated successfully, but these errors were encountered: