Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shields buttons colour theme is changed. Need to match Brave theme #17596

Closed
srirambv opened this issue Aug 20, 2021 · 1 comment · Fixed by brave/brave-core#9830
Closed

Shields buttons colour theme is changed. Need to match Brave theme #17596

srirambv opened this issue Aug 20, 2021 · 1 comment · Fixed by brave/brave-core#9830
Assignees
@samartnik
Labels
feature/themes OS/Android Fixes related to Android browser functionality QA Pass - Android ARM QA Pass - Android Tab QA/Yes release-notes/exclude
Milestone
1.29.x - Release

Comments

@srirambv
Copy link
Contributor

Description

Shields buttons colour theme is changed. Need to match Brave theme

Steps to reproduce

  1. Open Shields on a page

Actual result

1.28.106 (CR 92) 1.30.34 (CR93)
image image

Expected result

Use Brave theme for buttons

Issue reproduces how often

Easy

Version/Channel Information:

  • Can you reproduce this issue with the current Play Store version? NA
  • Can you reproduce this issue with the current Play Store Beta version? NA
  • Can you reproduce this issue with the current Play Store Nightly version? Yes

Device details

  • Install type (ARM, x86): ARM
  • Device type (Phone, Tablet, Phablet): Phone
  • Android version: 11

Brave version

1.30.34

Website problems only

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards?NA
  • Is the issue reproducible on the latest version of Chrome? NA

Additional information
@srirambv srirambv added QA/Yes release-notes/exclude feature/themes OS/Android Fixes related to Android browser functionality labels Aug 20, 2021
@srirambv srirambv mentioned this issue Aug 23, 2021
Closed
This was referenced Aug 23, 2021
Merged
Merged
@samartnik samartnik self-assigned this Aug 24, 2021
@mkarolin mkarolin mentioned this issue Aug 24, 2021
Merged
24 tasks
@srirambv
Copy link
Contributor Author

Verification passed on Oppo Reno 5 with Android 11 running 1.29.74 x64 build

  • Verified shields button colour matches Brave colour theme
Shields On Shields Off
image image

Verification passed on Oppo Reno 5 with Android 11 running 1.29.74 x64 build

  • Verified shields button colour matches Brave colour theme
Shields On Shields Off
image image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@samartnik samartnik

Labels
feature/themes OS/Android Fixes related to Android browser functionality QA Pass - Android ARM QA Pass - Android Tab QA/Yes release-notes/exclude
Projects
None yet
Milestone
1.29.x - Release
Development

Successfully merging a pull request may close this issue.

[Android] Fixed colors for the dark theme brave/brave-core
3 participants
@kjozwiak @srirambv @samartnik