[Android] Add Gemini user wallet support

[Miyayes]

Description

Add support for Gemini user wallets on Android.

Test plan

https://github.com/brave/internal/issues/865

[prashasth-nair]

Can you please tell will the next update will add support for Gemini in android?

[aman-m1]

I am also patiently waiting for this. Gemini was available for creators in August-2020 and it became available in desktop a year later in August-2021. At that time a couple of months was estimate guess of some moderators on reddit and community page for it to be available on Android pending rewrite of rewards UI, which is not yet released. I hope it doesn't get dragged into another year.

[prashasth-nair]

Can you tell when will this feature will be added?

[aman-m1]

New rewards UI on Android has landed in Nightly v1.35.44 and it looks good.

Bitflyer has also been added a while ago- #18439
1 Feb 2022 is due date for stable release of v1.35.xx

[Miyayes]

@aman-m1, there's an even newer UI now that looks even better. Still some polishing to do #20207, but is even further improved :)

@prashasth-nair As soon as we can after v1.35.

[aman-m1]

@Miyayes Looking forward to it.

Also I would point out one thing, the UI card on brave://rewards doesn't fit in perfectly. It would be good if we don't have to swipe left and right to get its full view. Here is a video-

Record_2021-12-23-23-09-11.mp4

[Miyayes]

@Miyayes Looking forward to it.

Also I would point out one thing, the UI card on brave://rewards doesn't fit in perfectly. It would be good if we don't have to swipe left and right to get its full view. Here is a video-

Record_2021-12-23-23-09-11.mp4

I think this will be solved with #20173

[thevirajshelke]

So is this feature of supporting Gemini wallet on Android in progress or it's already out in the Nightly releases?

Also, when can we expect a stable release with this feature?

What users expect is that all of the BAT coins generated should somehow go to the same wallet Uphold, Gemini, etc. As of now if someone uses Gemini on the desktop, laptop & other device is Android we can't save BAT in a single place! So this feature is very important from the user experience perspective!

Hoping to see this asap in the subsequent releases! Kudos to Brave Team! Keep it up! :)

[Miyayes]

@thevirajshelke, it is not yet in Nightly. It'll start development quite soon; we are about to land all the foundation work in 1.35, so I think we can quickly sprint toward Gemini support after 1.35.

[thevirajshelke]

So right now the latest stable version rolled out is 1.33.106 and we can expect this feature in versions after 1.35 which sounds good & quick @Miyayes. That update will surely improve the user experience a lot since we all will have a common wallet (place) to dump all out BAT from any device! :-) Looking forward to that update! Thanks a lot, @Miyayes & brave team!

[CovertLeopard]

If you need additional testers for Gemini wallet support in android, let me know. I've been patiently waiting for this feature and have no problems beta testing it on my Pixel 6 Pro if asked. @Miyayes

[newuser-web]

@Miyayes @emerick Which version of nightly are you targeting?

[aman-m1]

As per bat-chriscat in v1.38.x which is the current version in Nightly link.

[varma61923]

when can we expect gemini wallet support for android ?

[aman-m1]

Amazing. Can we uplift it also?

[Miyayes]

@aman-m1 We are keeping this in 1.38.x and will not be uplifting it. Thanks.

[Saoiray]

Well, glad to see it's "Done" but I wish we'd have info on when to expect 1.38 to be released. This and the removal of the device limit are the two more frequent things posted on Brave Community. Anyway, thanks for keeping us updated @Miyayes and we're definitely hoping to see it roll out soon.

[Zainzzkk]

^ I agree with above. It is "Done" for nightly but not for production version. Not everyone is comfortable using nightly and technically it is not done yet for the live full brave android version. Would be nice to know when it will be available for android users not on nightly or when to expect certain big releases

[LaurenWags]

@Carlancer this is moving through our channels, it is currently available on Nightly (1.39.x at the moment) and Beta (1.38.x at the moment).

Once 1.38.x hits release channel (anticipated to be on or around April 26 per https://github.com/brave/brave-browser/wiki/Brave-Release-Schedule#release-channel-dates), then this feature will be available on the release version.

Note - the dates on https://github.com/brave/brave-browser/wiki/Brave-Release-Schedule#release-channel-dates are not set in stone and may have a bit of variation. We try to release as close to them as possible.

[LaurenWags]

Verified on Google Pixel 3 XL with Android 12 running 1.38.83 / 1.38.93

Verification notes can be found under https://github.com/brave/internal/issues/865#issuecomment-1092958660

---

Verified on Samsung J7 Neo with Android 7 running 1.38.93 / 1.38.104

Verification notes can be found under https://github.com/brave/internal/issues/865#issuecomment-1104384735

[Uni-verse]

Verification Completed on Samsung Tab S7 using

Brave	1.38.106 Chromium: 101.0.4951.41 (Official Build) (64-bit) 
Revision	93c720db8323b3ec10d056025ab95c23a31997c9-refs/branch-heads/4951@{#904}
OS	Android 12; Build/SP1A.210812.016

PASS - Gemini available in non-Japan region

PASS - Gemini not available in Japan region

PASS - Successfully link Gemini

PASS - Attempt to link non-KYC'd Gemini account

1. Clean profile, non-Japan region, enable staging env and relaunch as necessary
2. Enable Rewards
3. Select Unverified and login with non-KYC'd Gemini account
4. Confirm no BAT balance shows in panel, on brave://rewards page, etc
5. Confirm error message is shown indicating that KYC must be completed

example	example

PASS - Gemini Disconnect/Reconnect

PASS - Switch from Uphold to Gemini (Disconnect/Reconnect)

1. Clean profile, non-Japan region, enable staging env and relaunch as necessary
2. Enable Rewards
3. Select Unverified and login with Uphold KYC'd account
4. Confirm UI shows Uphold branding and balance
5. From "Verified" drop down on panel or brave://rewards page, explicitly disconnect from Uphold
6. Confirm UI returns to pre-connected state ("Unverified" is shown, no balance)
7. Select Unverified and login with Gemini KYC'd account
8. Confirm UI shows Gemini branding and balance

PASS - Simulate natural Disconnect

example	example	example

PASS - One-Time Tips - KYC'd Gemini (tipping from Gemini KYC wallet to Gemini creator will take time, this is known/expected)

PASS - Userdrain - Claim Ad grant before linking Gemini

1. Clean profile, non-Japan region, enable staging env + verbose logs and relaunch as necessary
2. Enable Rewards
3. Restore rewards account (backup words) with a waiting Ad grant
4. Claim the Ad grant
5. Select Unverified and login with a Gemini account
6. After successful connection/linking, confirm the Ad grant BAT is sent to Gemini account using logs and brave://rewards-internals

example	example	example	example

PASS - Confirm Uphold still able to be connected in non-JP region + UI checks

1. Clean profile, non-Japan region, enable staging env and relaunch as necessary
2. Enable Rewards
3. Select Unverified and login with KYC'd Uphold account
4. Check rewards UI (panel, brave://rewards, etc) and confirm Uphold branding is observed
5. Confirm when you click on "Verified" text on panel the drop down shows Uphold branding
6. Confirm when you click on "Verified" text on brave://rewards page the drop down shows Uphold branding
7. Confirm expected noted BAT balance shows in panel, on brave://rewards page, and in tip banners
8. Confirm able to do a one-time tip to an Uphold creator and balance decreases as expected

example	example	example	example	example	example

PASS - Uphold - minimum BAT required

1. Clean profile, non-Japan region, enable staging env and relaunch as necessary
2. Enable Rewards
3. Click on "Unverified" from panel or brave://rewards
4. Click thru the verification modal and confirm you see message about 2 BAT required (existing functionality)
5. Claim UGP grant
6. Click on "Unverified" again
7. Confirm verification popup has Uphold and clicking on Uphold option takes you to Uphold sandbox

example	example

PASS - One-Time Tips - KYC'd Uphold

Reference: Tipping Matrix - https://docs.google.com/spreadsheets/d/1WbCD6Hgm0ASThJqlmkVvhwmMGwg5Vtz9X5_t5rR15_0/edit#gid=0

1. Clean profile, non-Japan region, enable staging env and relaunch as necessary
2. Enable Rewards
3. Connect a KYC'd Uphold account
4. Confirm balance is shown in UI.
5. Attempt to tip an unverified publisher. Confirm this publisher shows the messaging on panel/tip banners that indicates they are not verified.
6. Confirm tip goes to "Pending" list, is not deducted from balance, and does not show in "Tips" on brave://rewards
7. Attempt to tip a connected, but not KYC'd publisher. Confirm this publisher shows messaging on panel/banners indicating they cannot accept tips.
8. Confirm tip is not deducted from balance, and does not show in "Tips" on brave://rewards
9. Attempt to tip a KYC'd Uphold publisher. Confirm this publisher does not show any messaging on panel/banners indicating they cannot accept tips.
10. Confirm tip is deducted from balance and shows in "Tips" on brave://rewards. Confirm the tip shows on Contributions page of brave://rewards-internals.
11. Confirm both the tip amount (95%) and the Brave fee (5%) are sent by viewing the logs.
12. Attempt to tip a KYC'd bitFlyer publisher. Confirm this publisher shows messaging on panel/banners indicating they cannot accept tips.
13. Confirm tip is not deducted from balance, and does not show in "Tips" on brave://rewards
14. Attempt to tip a KYC'd Gemini publisher. Confirm this publisher shows messaging on panel/banners indicating they cannot accept tips.
15. Confirm tip is not deducted from balance, and does not show in "Tips" on brave://rewards

PASS - Confirm bitFlyer still able to be connected in JP region + UI checks

1. Clean profile, Japan region, enable staging env and relaunch as necessary
2. Enable Rewards
3. Select Unverified and login with bitFlyer account from one of the "Basic cases" section of https://docs.google.com/spreadsheets/d/1ko9q8IslO6R7FT37IqNoJG5zBRfPoQbBlu2MnHbSORE/edit#gid=0
4. Check rewards UI (panel, brave://rewards, etc) and confirm bitFlyer branding is observed
5. Confirm when you click on "Verified" text on panel the drop down shows bitFlyer branding
6. Confirm when you click on "Verified" text on brave://rewards page the drop down shows bitFlyer branding
7. Confirm expected noted BAT balance shows in panel, on brave://rewards page, and in tip banners
8. Confirm able to do a one-time tip to a bitFlyer creator and balance decreases as expected (note, if you wait more than 7 minutes since logging in, you will be disconnected, this is a feature of staging env to allow testing of simulated disconnect)

example	example	example

PASS - bitFlyer Auto Contribute

1. Clean profile, Japan region, enable staging env and relaunch as necessary
2. Enable Rewards
3. Select Unverified and login with bitFlyer KYC'd account
4. Confirm on brave://rewards that there is no Auto Contribute section
5. Confirm AC is not listed on panel either

PASS - One-Time Tips - Anon (no Gemini, Uphold, or bitFlyer)

Reference: Tipping Matrix - https://docs.google.com/spreadsheets/d/1WbCD6Hgm0ASThJqlmkVvhwmMGwg5Vtz9X5_t5rR15_0/edit#gid=0

1. Clean profile, non-Japan region, enable staging env and relaunch as necessary
2. Enable Rewards
3. Do not connect a KYC'd Gemini or Uphold account
4. Claim UGP grant (anon status)
5. Attempt to tip an unverified publisher. Confirm this publisher shows the messaging on panel/tip banners that indicates they are not verified.
6. Confirm tip goes to "Pending" list, is not deducted from balance, and does not show in "Tips" on brave://rewards
7. Attempt to tip a connected, but not KYC'd publisher. Confirm this publisher does not show any messaging on panel/banners indicating they cannot accept tips.
8. Confirm tip is deducted from balance and shows in "Tips" on brave://rewards. Confirm the tip shows on Contributions page of brave://rewards-internals.
9. Attempt to tip a KYC'd Uphold publisher. Confirm this publisher does not show any messaging on panel/banners indicating they cannot accept tips.
10. Confirm tip is deducted from balance and shows in "Tips" on brave://rewards. Confirm the tip shows on Contributions page of brave://rewards-internals.
11. Attempt to tip a KYC'd bitFlyer publisher. Confirm this publisher does not show any messaging on panel/banners indicating they cannot accept tips.
12. Confirm tip is deducted from balance and shows in "Tips" on brave://rewards. Confirm the tip shows on Contributions page of brave://rewards-internals.
13. Attempt to tip a KYC'd Gemini publisher. Confirm this publisher does not show any messaging on panel/banners indicating they cannot accept tips.
14. Confirm tip is deducted from balance and shows in "Tips" on brave://rewards. Confirm the tip shows on Contributions page of brave://rewards-internals.