Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Other sections in onboarding should open in new tabs or have "back" buttons #1739

Closed
bflora opened this issue Oct 19, 2018 · 3 comments
Closed

Comments

@bflora
Copy link

bflora commented Oct 19, 2018

When a user goes through Brave onboarding, they are encouraged to take a few detours like "Enable Brave reward". When a user engages with one of these by clicking the button, they are taken out of the onboarding UX and "stranded" in the new area. These buttons should either open in new tabs or the new sections should have obvious links to return to the onboarding flow.

Example:

image

Description

Steps to Reproduce

Actual result:

Expected result:

Reproduces how often:

Brave version (brave://version info)

Reproducible on current release:

  • Does it reproduce on brave-browser dev/beta builds?
  • Does it reproduce on browser-laptop?

Website problems only:

  • Does the issue resolve itself when disabling Brave Shields?
  • Is the issue reproducible on the latest version of Chrome?

Additional Information

@NejcZdovc NejcZdovc added this to the 0.56.x - Beta milestone Oct 19, 2018
@rossmoody rossmoody self-assigned this Oct 19, 2018
@rossmoody
Copy link
Contributor

This will get auto fixed when new onboarding process is implemented. @cezaraugusto

@cezaraugusto
Copy link
Contributor

done in brave/brave-core#708, thanks for reporting!

@srirambv
Copy link
Contributor

srirambv commented Oct 26, 2018

Verification Passed on

Brave 0.57.3 Chromium: 70.0.3538.67 (Official Build) dev (64-bit)
Revision 9ab0cfab84ded083718d3a4ff830726efd38869f-refs/branch-heads/3538@{#1002}
OS Linux
  • Verified all links in welcome page opened in individual new tabs

Verification Passed on

Brave 0.56.7 Chromium: 70.0.3538.77 (Official Build) beta (64-bit)
Revision 0f6ce0b0cd63a12cb4eccea3637b1bc9a29148d9-refs/branch-heads/3538@{#1039}
OS Windows
  • Verified all links in welcome page opened in individual new tabs

Verified passed with

Brave 0.56.7 Chromium: 70.0.3538.77 (Official Build) beta(64-bit)
Revision 0f6ce0b0cd63a12cb4eccea3637b1bc9a29148d9-refs/branch-heads/3538@{#1039}
OS Mac OS X
  • Verified all links in welcome page opened in individual new tabs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment