Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent main menu capitalization #16503

Closed
wyatt400 opened this issue Jun 17, 2021 · 6 comments · Fixed by brave/brave-core#8961
Closed

Inconsistent main menu capitalization #16503

wyatt400 opened this issue Jun 17, 2021 · 6 comments · Fixed by brave/brave-core#8961
Assignees
Labels
OS/Desktop polish Nice to have — usually related to front-end/visual tasks priority/P4 Planned work. We expect to get to it "soon". QA Pass-macOS QA/Yes release-notes/exclude

Comments

@wyatt400
Copy link

wyatt400 commented Jun 17, 2021

Description

The main menu in Brave is capitalized inconsistently with title case and sentence case. As with Chromium's go/punctuation-standards as well as Brave's standards, these should all be sentence case.

Steps to Reproduce

  1. Open Brave
  2. Click the three lines at the top right corner to open the main menu

Actual result:

Soon, this seems to also affect "New Private window too, which should be "New private window
image

Sentence and title case are mixed.

Expected result:

Only sentence case is used, except for Brave's proper nouns such as Brave Rewards.

"Create a New Profile" should be "Create a new profile"
"Open Guest Window" should be "Open guest window"
"Report a Broken Site" should be "Report a broken site"
"New Private window" should be "New private window"

Reproduces how often:

Always

Brave version (brave://version info)

Brave 1.27.68 Chromium: 91.0.4472.106 (Official Build) nightly (64-bit)

Version/Channel Information:

  • Can you reproduce this issue with the current release? Yes
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? No
  • Does the issue resolve itself when disabling Brave Rewards? No
  • Is the issue reproducible on the latest version of Chrome? No

Miscellaneous Information:

I've opened a pull request here for it, it has a very simple solution. brave/brave-core#8961

@rebron rebron added priority/P4 Planned work. We expect to get to it "soon". polish Nice to have — usually related to front-end/visual tasks labels Jun 21, 2021
@rebron rebron added needs-discussion Although the issue is clear, we haven't yet reached a decision about the right solution. and removed needs-discussion Although the issue is clear, we haven't yet reached a decision about the right solution. labels Jun 21, 2021
@wyatt400
Copy link
Author

wyatt400 commented Jul 2, 2021

@rebron Any progress?

@rebron
Copy link
Collaborator

rebron commented Jul 16, 2021

@wyatt400 Having a couple more people look but this looks like we're good to go. #16982 looks like a dupe.

cc: @stephendonner @karenkliu

@wyatt400
Copy link
Author

@rebron @srirambv Do you guys think we can get the issue fixed soon? If so, when? Because I don't know how to do this other than editing brave-generated-resources.grd, which has a lot of flaws.

@wyatt400
Copy link
Author

"Create a New Profile" should be "Create a new profile"
"Open Guest Window" should be "Open guest window"
"Report a Broken Site" should be "Report a broken site"
"New Private window" should be "New private window"

@stephendonner
Copy link

Filed #17309 for Windows and Linux, and #17308 for macOS, to finish off/correct the above landing.

@stephendonner
Copy link

Verified PASSED using

Brave 1.29.50 Chromium: 92.0.4515.131 (Official Build) nightly (x86_64)
Revision 6b8d6c56ce21e38a72f7c4becb5abc1fa5134f29-refs/branch-heads/4515@{#1933}
OS macOS Version 11.5.1 (Build 20G80)

with the caveat that the changes are incomplete and will be addressed in #17309 for Windows and Linux, and #17308 for macOS.

Changes:

  • Report a broken site
  • Create a new profile
  • Open guest window
macOS Windows 10
macOS win10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OS/Desktop polish Nice to have — usually related to front-end/visual tasks priority/P4 Planned work. We expect to get to it "soon". QA Pass-macOS QA/Yes release-notes/exclude
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants