Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename the laptop-updates.brave.com endpoint #16374

Open
fmarier opened this issue Jun 11, 2021 · 4 comments
Open

Rename the laptop-updates.brave.com endpoint #16374

fmarier opened this issue Jun 11, 2021 · 4 comments
Assignees
Labels
network/startup requests OS/Android Fixes related to Android browser functionality OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. privacy

Comments

@fmarier
Copy link
Member

fmarier commented Jun 11, 2021

Historically, that endpoint was used for browser updates (in the Muon days). Then the stats / referral ping was added to it as a secondary use.

Now that Muon updates are no longer sent to these old clients, this endpoint is primarily for stats. We should rename it so that the name reflects the nature of the traffic.

Historical uses:

Current uses:

  • usage pings on all platforms (includes referral code for the first 90 days if any)
  • referral pings when applicable (at first run, and then intermittently until 30 days later when it stops)
  • Windows installation events (where things failed during install)
  • feedback submissions from Android users who rate the app
@fmarier fmarier added privacy OS/Android Fixes related to Android browser functionality OS/Desktop labels Jun 11, 2021
@fmarier
Copy link
Member Author

fmarier commented Jun 11, 2021

Here's a concrete suggestion:

  • metrics.brave.com for usage pings, referral pings, and installation events
  • feedback.brave.com for webcompat and android feedback

Leave partner headers on laptop-updates for now and work towards removing that mechanism entirely.

@fmarier
Copy link
Member Author

fmarier commented Jun 15, 2021

Leave partner headers on laptop-updates for now and work towards removing that mechanism entirely.

@diracdeltas has a better interim solution for this: remove the /promo/custom-headers endpoint and have this list be hard-coded into brave-core until we can remove it entirely. We're not supposed to be adding to it and so it doesn't need to be updatable outside of the regular release trains. I filed #16455 for this.

@ShivanKaul ShivanKaul added the priority/P3 The next thing for us to work on. It'll ride the trains. label Jul 27, 2021
@fmarier
Copy link
Member Author

fmarier commented Jan 24, 2022

metrics.brave.com and feedback.brave.com were added in https://github.com/brave/devops/pull/6699.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
network/startup requests OS/Android Fixes related to Android browser functionality OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. privacy
Projects
None yet
Development

No branches or pull requests

4 participants