Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename Brave Together to Brave Talk in the sidebar #16360

Closed
stephendonner opened this issue Jun 11, 2021 · 3 comments · Fixed by brave/brave-core#9134
Closed

Rename Brave Together to Brave Talk in the sidebar #16360

stephendonner opened this issue Jun 11, 2021 · 3 comments · Fixed by brave/brave-core#9134
Labels
feature/sidebar Relating to Brave's Sidebar feature good first issue OS/Desktop QA Pass-macOS QA/Yes release-notes/exclude
Milestone
1.28.x - Release

Comments

@stephendonner
Copy link

Description

Rename Brave Together to Brave Talk in the sidebar

Steps to Reproduce

  1. new profile
  2. launch Brave
  3. enable sidebar via brave://flags
  4. hover over the video-camera icon and look at the tooltip

Actual result:

Tooltip says Brave Together

Screen Shot 2021-06-11 at 12 05 28 AM

Expected result:

Tooltip says Brave Talk

Reproduces how often:

100%

Brave version (brave://version info)

Brave | 1.27.57 Chromium: 91.0.4472.101 (Official Build) nightly (x86_64)
Revision | af52a90bf87030dd1523486a1cd3ae25c5d76c9b-refs/branch-heads/4472@{#1462}
OS | macOS Version 11.4 (Build 20F71)
JavaScript

/cc @mattmcalister @karenkliu @simonhong
@stephendonner stephendonner added good first issue OS/Desktop feature/sidebar Relating to Brave's Sidebar feature labels Jun 11, 2021
@aniketartani
Copy link

aniketartani commented Jun 11, 2021 •
edited
Loading

It is really easy to change it. @brave-browser-releases Assign me I will do it asap.

@simonhong
Copy link
Member

It is really easy to change it. @brave-browser-releases Assign me I will do it asap.

@aniketartani Assigned. Thanks

@simonhong simonhong mentioned this issue Jun 16, 2021
Merged
24 tasks
@bsclifton bsclifton added this to the 1.28.x - Nightly milestone Jun 16, 2021
@stephendonner
Copy link
Author

Verified FIXED using

Brave 1.28.3 Chromium: 91.0.4472.106 (Official Build) nightly (x86_64)
Revision 574f7b38e4e7244c92c4675e902e8f8e3d299ea7-refs/branch-heads/4472@{#1477}
OS macOS Version 11.4 (Build 20F71)

Confirmed the tooltip now reads Brave Talk

Screen Shot 2021-06-17 at 2 54 40 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature/sidebar Relating to Brave's Sidebar feature good first issue OS/Desktop QA Pass-macOS QA/Yes release-notes/exclude
Projects
None yet
Milestone
1.28.x - Release
Development

Successfully merging a pull request may close this issue.

Rename Brave Together to Brave Talk in the sidebar #16360
4 participants
@stephendonner @bsclifton @simonhong @aniketartani