Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce radius of corners on URL bar button hover shapes to match other button hovers #16290

Closed
bradleyrichter opened this issue Jun 9, 2021 · 4 comments · Fixed by brave/brave-core#9374
Closed

Reduce radius of corners on URL bar button hover shapes to match other button hovers #16290

bradleyrichter opened this issue Jun 9, 2021 · 4 comments · Fixed by brave/brave-core#9374
Assignees
@karenkliu @nullhook
Labels
design A design change, especially one which needs input from the design team OS/Desktop QA Pass-macOS QA/Yes release-notes/exclude
Milestone
1.29.x - Release

Comments

@bradleyrichter
Copy link

Good
image

Bad
image

Good
image
@bradleyrichter bradleyrichter added design A design change, especially one which needs input from the design team OS/Desktop labels Jun 9, 2021
@bradleyrichter bradleyrichter added this to the 1.26.x - Beta milestone Jun 9, 2021
@kjozwiak
Copy link
Member

Removing this from 1.26.x as there's no work nor a PR associated with this. Opened issues should only be added into milestones when they're release/blocking.

@kjozwiak kjozwiak removed this from the 1.26.x - Release milestone Jun 21, 2021
@nullhook nullhook self-assigned this Jul 2, 2021
@nullhook nullhook mentioned this issue Jul 8, 2021
Merged
24 tasks
@nullhook nullhook added this to the 1.29.x - Nightly milestone Jul 15, 2021
@rebron
Copy link
Collaborator

rebron commented Jul 15, 2021

Marked as QA/Yes, let's have @karenkliu QA clear this one.

@karenkliu
Copy link

lgtm 😃

@stephendonner
Copy link

Verified PASSED using

Brave 1.29.12 Chromium: 92.0.4515.101 (Official Build) nightly (x86_64)
Revision edb73f4fb624e2ea0cb6f5cc39c9e317ecd3535b-refs/branch-heads/4515@{#1536}
OS macOS Version 11.4 (Build 20F71)

Steps:

  1. new profile
  2. launched Brave
  3. hovered over toolbar-UI elements in both light and dark modes

Confirmed that hover highlights for toolbar-UI elements are now square, not rounded.

Screen Shot 2021-07-20 at 12 14 51 PM | Screen Shot 2021-07-20 at 12 15 29 PM | Screen Shot 2021-07-20 at 12 17 54 PM | Screen Shot 2021-07-20 at 12 18 07 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@karenkliu karenkliu

@nullhook nullhook

Labels
design A design change, especially one which needs input from the design team OS/Desktop QA Pass-macOS QA/Yes release-notes/exclude
Projects
None yet
Milestone
1.29.x - Release
Development

Successfully merging a pull request may close this issue.

Reduce corner radius on location bar icon brave/brave-core
7 participants
@stephendonner @petemill @karenkliu @kjozwiak @rebron @nullhook @bradleyrichter