Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go-ipfs component not updated until the 3rd restart #16184

Closed
Tracked by #17112
stephendonner opened this issue Jun 1, 2021 · 1 comment · Fixed by brave/brave-core#9135
Closed
Tracked by #17112

go-ipfs component not updated until the 3rd restart #16184

stephendonner opened this issue Jun 1, 2021 · 1 comment · Fixed by brave/brave-core#9135

Comments

@stephendonner
Copy link

stephendonner commented Jun 1, 2021

Description

go-ipfs component not updated until the 3rd restart

Steps to Reproduce

  1. new profile, launch Brave
  2. load brave://ipfs-internals/
  3. click Install and start
  4. under Node info at the bottom of the page, note Version: go-ipfs/0.7.0/
  5. quit Brave
  6. relaunch using --use-dev-goupdater-url
  7. click Start
  8. note Version: go-ipfs/0.7.0/ on brave://ipfs-internals
  9. quit Brave
  10. relaunch using --use-dev-goupdater-url
  11. click Start
  12. note Version: go-ipfs/0.7.0/ on brave://ipfs-internals
  13. quit Brave
  14. relaunch using --use-dev-goupdater-url
  15. click Start
  16. now, note Version: go-ipfs/0.9.0-rc1/ on brave://ipfs-internals

Actual result:

It takes 3 relaunches with --use-dev-goupdater-url, after the initial launch without, to pick up the go-ipfs/0.9.0-rc1 component.

Expected result:

I'm not actually sure, but if you launch at step #1 with --use-dev-goupdater-url with a new profile, it picks it up right away.

Reproduces how often:

100%

Brave version (brave://version info)

Brave 1.27.33 Chromium: 91.0.4472.77 (Official Build) nightly (x86_64)
Revision 1cecd5c8a856bc2a5adda436e7b84d8d21b339b6-refs/branch-heads/4472@{#1246}
OS macOS Version 11.4 (Build 20F71)
@stephendonner stephendonner changed the title go-ipfs component not updated until the 4th restart go-ipfs component not updated until the 3rd restart Jun 1, 2021
@spylogsster spylogsster self-assigned this Jun 15, 2021
@spylogsster spylogsster added this to the 1.27.x - Nightly milestone Jun 15, 2021
@stephendonner
Copy link
Author

Verified PASSED using the testplan from brave/brave-core#9135 with

Brave 1.27.76 Chromium: 91.0.4472.114 (Official Build) dev (x86_64)
Revision 4bb19460e8d88c3446b360b0df8fd991fee49c0b-refs/branch-heads/4472@{#1496}
OS macOS Version 11.4 (Build 20F71)

Steps:

  1. new profile, launch Brave
  2. load brave://ipfs-internals/
  3. click Install and start
  4. under Node info at the bottom of the page, note Version: go-ipfs/0.7.0/
  5. quit Brave
  6. relaunch using --use-dev-goupdater-url
  7. click Start
  8. wait until updates downloaded
  9. click Restart node
  10. check version, should be 0.9.0-rc1

Confirmed version 0.9.0-rc1 was downloaded, installed, and used.

default 0.7.0 updated to 0.9.0-rc1
Screen Shot 2021-06-22 at 12 44 22 PM Screen Shot 2021-06-22 at 12 44 59 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants