Installing 1.27.12 from Brave-Browser-Nightly-universal.pkg crashes on launch with M1

[LaurenWags]

Description

Installing 1.27.12 from Brave-Browser-Nightly-universal.pkg crashes on launch on M1.

Installing the other versions of 1.27.12 do not crash on launch w/ M1:

• Brave-Browser-Nightly-universal.dmg
• Brave-Browser-Nightly-x64.dmg
• Brave-Browser-Nightly-x64.pkg

Also, installing previous Nightly with universal builds available (1.27.8), does not crash on M1.

Unsure if this is related to changes made to fix #16037.

Steps to Reproduce

1. Have M1 laptop
2. Install 1.27.12 from Brave-Browser-Nightly-universal.pkg file https://github.com/brave/brave-browser/releases/tag/v1.27.12
3. Attempt to launch --> crash on launch
4. Try one of the other available macOS versions
5. No crash on launch

Actual result:

Crash on launch

Expected result:

No crash

Reproduces how often:

100%

Brave version (brave://version info)

1.27.12 Brave-Browser-Nightly-universal.pkg file

Version/Channel Information:

• Can you reproduce this issue with the current release? no
• Can you reproduce this issue with the beta channel? no
• Can you reproduce this issue with the nightly channel? yes, but only 1.27.12, not 1.27.8

Other Additional Information:

• Does the issue resolve itself when disabling Brave Shields?
• Does the issue resolve itself when disabling Brave Rewards?
• Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

cc @bridiver @simonhong @rebron @mihaiplesa @kjozwiak

[bridiver]

I don’t think this matters if it only happens on nightly. By the time this reaches stable we won’t have a universal binary anymore

…

On May 24, 2021, at 5:14 AM, Lauren ***@***.***> wrote:  Description Installing 1.27.12 from Brave-Browser-Nightly-universal.pkg crashes on launch on M1. Installing the other versions of 1.27.12 do not crash on launch w/ M1: Brave-Browser-Nightly-universal.dmg Brave-Browser-Nightly-x64.dmg Brave-Browser-Nightly-x64.pkg Also, installing previous Nightly with universal builds available (1.27.8), does not crash on M1. Unsure if this is related to changes made to fix #16037. Steps to Reproduce Have M1 laptop Install 1.27.12 from Brave-Browser-Nightly-universal.pkg file https://github.com/brave/brave-browser/releases/tag/v1.27.12 Attempt to launch --> crash on launch Try one of the other available macOS versions No crash on launch Actual result: Crash on launch Expected result: No crash Reproduces how often: 100% Brave version (brave://version info) 1.27.12 Brave-Browser-Nightly-universal.pkg file Version/Channel Information: Can you reproduce this issue with the current release? no Can you reproduce this issue with the beta channel? no Can you reproduce this issue with the nightly channel? yes, but only 1.27.12, not 1.27.8 Other Additional Information: Does the issue resolve itself when disabling Brave Shields? Does the issue resolve itself when disabling Brave Rewards? Is the issue reproducible on the latest version of Chrome? Miscellaneous Information: cc @bridiver @simonhong @rebron @mihaiplesa @kjozwiak — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe.

[LaurenWags]

Reproducible with
Nightly 1.27.12 Brave-Browser-universal.pkg
Nightly 1.27.13 Brave-Browser-universal.pkg
Dev 1.26.41 Brave-Browser-universal.pkg
Beta 1.26.40 Brave-Browser-universal.pkg

Does not reproduce with
Nightly 1.27.17 Brave-Browser-universal.pkg
Release Candidate 1.25.68 Brave-Browser-universal.pkg

This seems to be working after #16054 was merged to Nightly and Release. Dev/Beta checks will be done once new builds are available (will need 1.26.42 or higher for these channels).

[bsclifton]

@LaurenWags safe to close?

[LaurenWags]

@bsclifton yep! Just wanted to check the following worked as expected before doing so:

Beta 1.26.43 Brave-Browser-Beta-universal.pkg
Dev 1.26.44 Brave-Browser-Dev-universal.pkg