Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider pulling in some options from Chromium's Accessibility settings page #15844

Open
stephendonner opened this issue May 13, 2021 · 3 comments
Assignees
Labels
accessibility design/needs-mock-up needs-mockup A feature which needs design mockup to be implemented. feature/settings needs-discussion Although the issue is clear, we haven't yet reached a decision about the right solution. OS/Desktop priority/P4 Planned work. We expect to get to it "soon".

Comments

@stephendonner
Copy link

stephendonner commented May 13, 2021

Description

Consider pulling in some options from Chromium's Accessibility settings page; filed this issue after speaking briefly to @rebron.

Steps to Reproduce

  1. load chrome://settings/accessibility in Chrome/Chromium
  2. note the available Accessibility options
  3. load brave://settings/ in Brave
  4. note the lack of available Accessibility options

Actual result:

We are missing the following:

  • Live Caption
  • Caption preferences
  • Show a quick highlight on the focused object
  • Navigate pages with a text cursor
  • Add accessibility features

Screen Shot 2021-05-13 at 1 18 37 PM

Live Caption -- as well as a few others -- are available, instead, as feature flags:

Screen Shot 2021-05-13 at 1 16 51 PM

Expected result:

image

Pull in everything except "Live Caption" (for now) and "Add accessibility features". Move 'Pressing Tab on a webpage highlights links as well as form fields' from 'Appearance' section to the new Accessibility section

Live Caption and associated settings downloads files from Google, so not sure if we want that, and if so, if we want to proxy that?

Reproduces how often:

100%

Brave version (brave://version info)

Brave 1.26.18 Chromium: 91.0.4472.38 (Official Build) nightly (x86_64)
Revision 8155e7afab5d695cf0e028f4d77203287523cda9-refs/branch-heads/4472_35@{#6}
OS macOS Version 11.3.1 (Build 20E241)

Version/Channel Information:

  • Can you reproduce this issue with the current release? yes
  • Can you reproduce this issue with the beta channel? yes
  • Can you reproduce this issue with the nightly channel? yes

Assets

Figma: https://www.figma.com/file/tLXWGCpNoiJxDZDdpfordj/?node-id=793%3A20267

@stephendonner stephendonner added accessibility feature/settings OS/Desktop needs-discussion Although the issue is clear, we haven't yet reached a decision about the right solution. labels May 13, 2021
@rebron rebron added the priority/P2 A bad problem. We might uplift this to the next planned release. label May 18, 2021
@karenkliu
Copy link

@rebron Designs added!

@rebron rebron added design/needs-mock-up needs-mockup A feature which needs design mockup to be implemented. priority/P2 A bad problem. We might uplift this to the next planned release. and removed priority/P2 A bad problem. We might uplift this to the next planned release. labels Dec 15, 2022
@farline99
Copy link

I hate this buttons highlight so much........

@rebron rebron moved this to P1 & P2 Backlog in Settings May 28, 2024
@Rogue-Git-Dev
Copy link

To this day the accessibility section is not existent in Brave's settings. This must change. Brave must incorporate more accessibility in the very least to have feature parity with Chromium.

@rebron rebron added priority/P4 Planned work. We expect to get to it "soon". and removed priority/P2 A bad problem. We might uplift this to the next planned release. labels Oct 7, 2024
@rebron rebron moved this from P1 & P2 Backlog to P4 backlog in Settings Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility design/needs-mock-up needs-mockup A feature which needs design mockup to be implemented. feature/settings needs-discussion Although the issue is clear, we haven't yet reached a decision about the right solution. OS/Desktop priority/P4 Planned work. We expect to get to it "soon".
Projects
Status: P4 backlog
Development

No branches or pull requests

6 participants