Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto-Contribute entries sometimes contain 'on YouTube' text twice #1565

Closed
LaurenWags opened this issue Oct 13, 2018 · 2 comments
Closed

Auto-Contribute entries sometimes contain 'on YouTube' text twice #1565

LaurenWags opened this issue Oct 13, 2018 · 2 comments

Comments

@LaurenWags
Copy link
Member

LaurenWags commented Oct 13, 2018

Description

Some Auto-Contribute table entries contain text text of 'on YouTube' twice.

Steps to Reproduce

  1. Be sure Rewards are enabled.
  2. Visit some youtube videos. --> Verify they are added to the table.
  3. Visit a site with an embedded YouTube video. --> Verify it is added to the table.

Actual result:

View table, some videos have 'on YouTube' text twice:
screen shot 2018-10-13 at 4 12 14 pm

Expected result:

Should not have this text twice

Reproduces how often:

easily

Brave version (chrome://version info)

Brave 0.55.13 Chromium: 70.0.3538.54 (Official Build) beta(64-bit)
Revision 4f8e578b6680574714e9ed3bb9f02922b4dde40d-refs/branch-heads/3538@{#937}
OS Mac OS X

Reproducible on current release:

  • Does it reproduce on brave-browser dev/beta builds? yes, reproduced on Beta
  • Does it reproduce on browser-laptop? no

Website problems only:

  • Does the issue resolve itself when disabling Brave Shields? n/a
  • Is the issue reproducible on the latest version of Chrome? n/a

Additional Information

Found while testing #986

@LaurenWags LaurenWags added this to the 0.56.x milestone Oct 13, 2018
@NejcZdovc NejcZdovc modified the milestones: 1.0, 1.x Backlog Oct 22, 2018
@rebron rebron added the priority/P4 Planned work. We expect to get to it "soon". label Oct 26, 2018
@rebron rebron modified the milestones: 1.x Backlog, 0.57.x - Dev Oct 26, 2018
@NejcZdovc NejcZdovc modified the milestones: 0.57.x - Dev, 0.56.x - Beta Oct 29, 2018
@NejcZdovc NejcZdovc self-assigned this Oct 29, 2018
@NejcZdovc
Copy link
Contributor

I think this was fixed with media panel. Let's retest when brave/brave-core#699 lands

@LaurenWags
Copy link
Member Author

LaurenWags commented Nov 1, 2018

Verified passed with

Brave 0.56.7 Chromium: 70.0.3538.77 (Official Build) beta(64-bit)
Revision 0f6ce0b0cd63a12cb4eccea3637b1bc9a29148d9-refs/branch-heads/3538@{#1039}
OS Mac OS X
  • Verified STR from description
    screen shot 2018-11-01 at 5 27 46 pm

Verification Passed on

Brave 0.56.8 Chromium: 70.0.3538.77 (Official Build) (64-bit)
Revision 0f6ce0b0cd63a12cb4eccea3637b1bc9a29148d9-refs/branch-heads/3538@{#1039}
OS Windows

image

Verification Passed on

Brave 0.56.8 Chromium: 70.0.3538.77 (Official Build) (64-bit)
Revision 0f6ce0b0cd63a12cb4eccea3637b1bc9a29148d9-refs/branch-heads/3538@{#1039}
OS Linux

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants