Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Manage Your Wallet" modal messaging in JP region #15420

Closed
LaurenWags opened this issue Apr 21, 2021 · 3 comments · Fixed by brave/brave-core#8618
Closed

"Manage Your Wallet" modal messaging in JP region #15420

LaurenWags opened this issue Apr 21, 2021 · 3 comments · Fixed by brave/brave-core#8618

Comments

@LaurenWags
Copy link
Member

Description

Regardless of bF flag status, bF is mentioned on the "Manage Your Wallet" modal. Should only be mentioned when flag is enabled (currently not default).

Steps to Reproduce

pre-req: have OS set to Japan

  1. Clean profile, staging env
  2. Enable Rewards
  3. Open Manage Your Wallet modal

Actual result:

Screen Shot 2021-04-21 at 14 55 50

Expected result:

If flag= disabled (currently default), no mention of bF on this page.

Reproduces how often:

easily

Brave version (brave://version info)

1.24.x

Version/Channel Information:

  • Can you reproduce this issue with the current release? 1.23.x mentions Uphold which is also wrong
  • Can you reproduce this issue with the beta channel? 1.24.x yes
  • Can you reproduce this issue with the nightly channel? 1.25.x yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

cc @Miyayes @zenparsing @emerick

@Miyayes
Copy link
Collaborator

Miyayes commented Apr 22, 2021

I consider this a wontfix, since flag-disabled state will not be the standard, and is only a short-term temporary state.

@LaurenWags
Copy link
Member Author

Per discussion with @zenparsing QA needs to check that the "If you'd like to..." text is removed from this screen.

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented May 7, 2021

Verification passed on


Brave | 1.24.83 Chromium: 90.0.4430.93 (Official Build) (64-bit)
-- | --
Revision | 4df112c29cfe9a2c69b14195c0275faed4e997a7-refs/branch-heads/4430@{#1348}
OS | Windows 10 OS Version 2004 (Build 19041.928)

  • Verified the test plan from Miscellaneous bitFlyer fixes brave-core#8618
    Confirmed that when region = Japan and bitFlyer is OFF, text does not display.
    Confirmed that when region = Japan and bitFlyer is ON, then text does display and mentions bitFlyer as expected.
bitFlyer = OFF bitFlyer = ON
image image

Confirmed that when region = IN and bitFlyer is OFF, text is shown and mentions Uphold as expected.
Confirmed that when region = IN and bitFlyer is ON, text is shown and mentions Uphold as expected.

bitFlyer = OFF bitFlyer = ON
image image

Verified passed with

Brave | 1.24.83 Chromium: 90.0.4430.93 (Official Build) (x86_64)
-- | --
Revision | 4df112c29cfe9a2c69b14195c0275faed4e997a7-refs/branch-heads/4430@{#1348}
OS | macOS Version 10.15.7 (Build 19H1030)

Verified STR from description and brave/brave-core#8618 (comment)

Japan/Japanese

Confirmed that when region = Japan and bitFlyer is ON (default), then text does display and mentions bitFlyer as expected.
Confirmed that when region = Japan and bitFlyer is OFF (via flags), text does not display.

bitFlyer = ON (default) bitFlyer = OFF (via flags)
japanese - bF ON (default) Japanese - bF OFF (flag)
US/English

Confirmed that when region = US and bitFlyer is OFF (default), text is shown and mentions Uphold as expected.
Confirmed that when region = IN and bitFlyer is ON (via flags), text is shown and mentions Uphold as expected.

bitFlyer = OFF (default) bitFlyer = ON (via flags)
US - bF OFF (default) US - bF ON (flag)

Verification passed on

Brave 1.24.81 Chromium: 90.0.4430.93 (Official Build) (64-bit)
Revision 4df112c29cfe9a2c69b14195c0275faed4e997a7-refs/branch-heads/4430@{#1348}
OS Ubuntu 18.04 LTS

Verified test plan from the description

Japan/Japanese

Confirmed that when region = Japan and bitFlyer is ON (default), then text does display and mentions bitFlyer as expected.
Confirmed that when region = Japan and bitFlyer is OFF (via flags), text does not display.

bitFlyer = ON (default) bitFlyer = OFF (via flags)
image image
US/English

Confirmed that when region = US and bitFlyer is OFF (default), text is shown and mentions Uphold as expected.
Confirmed that when region = US and bitFlyer is ON (via flags), text is shown and mentions Uphold as expected.

bitFlyer = OFF (default) bitFlyer = ON (via flags)
image image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment