-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"Manage Your Wallet" modal messaging in JP region #15420
Comments
I consider this a |
Per discussion with @zenparsing QA needs to check that the "If you'd like to..." text is removed from this screen. |
Verification passed on
Confirmed that when region = IN and bitFlyer is OFF, text is shown and mentions Uphold as expected.
Verified passed with
Verified STR from description and brave/brave-core#8618 (comment) Japan/JapaneseConfirmed that when region = Japan and bitFlyer is ON (default), then text does display and mentions bitFlyer as expected.
US/EnglishConfirmed that when region = US and bitFlyer is OFF (default), text is shown and mentions Uphold as expected.
Verification passed on
Verified test plan from the description |
Description
Regardless of bF flag status, bF is mentioned on the "Manage Your Wallet" modal. Should only be mentioned when flag is enabled (currently not default).
Steps to Reproduce
pre-req: have OS set to Japan
Actual result:
Expected result:
If flag= disabled (currently default), no mention of bF on this page.
Reproduces how often:
easily
Brave version (brave://version info)
1.24.x
Version/Channel Information:
Other Additional Information:
Miscellaneous Information:
cc @Miyayes @zenparsing @emerick
The text was updated successfully, but these errors were encountered: