Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change tab_host from string to GURL in AdBlockBaseService::ShouldStartRequest #15291

Open
antonok-edm opened this issue Apr 14, 2021 · 0 comments
Open

Change tab_host from string to GURL in AdBlockBaseService::ShouldStartRequest #15291

antonok-edm opened this issue Apr 14, 2021 · 0 comments
Assignees
@antonok-edm
Labels
dev-concern OS/Android Fixes related to Android browser functionality OS/Desktop

Comments

@antonok-edm
Copy link
Collaborator

Followup for brave/brave-core#8281 (comment). The way we're currently using url::Origin::CreateFromNormalizedTuple isn't ideal and we can avoid it entirely by just passing a GURL directly. This applies to the recently added AdBlockBaseService::GetCspDirectives as well, which uses a similar pattern.
@antonok-edm antonok-edm added dev-concern OS/Android Fixes related to Android browser functionality OS/Desktop labels Apr 14, 2021
@antonok-edm antonok-edm self-assigned this Apr 14, 2021
@antonok-edm antonok-edm mentioned this issue Apr 14, 2021
Merged
24 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@antonok-edm antonok-edm

Labels
dev-concern OS/Android Fixes related to Android browser functionality OS/Desktop
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@antonok-edm