Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

top level domain blocking enabled with Standard blocking - follow up to #15095 #15242

Closed
kjozwiak opened this issue Apr 12, 2021 · 3 comments · Fixed by brave/brave-core#8511
Closed
Assignees
Labels
bug feature/shields The overall Shields feature in Brave. OS/Android Fixes related to Android browser functionality OS/Desktop privacy/feature User-facing privacy- & security-focused feature work. privacy-pod Feature work for the Privacy & Web Compatibility pod QA Pass - Android ARM QA Pass - Android Tab QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-All-Platforms QA/Yes release-notes/exclude

Comments

@kjozwiak
Copy link
Member

kjozwiak commented Apr 12, 2021

Description

As per #15095, we should be disabling top level domain blocking in Standard mode and should only be blocking when a user has selected Aggressive via the Brave Shields settings.

Steps to Reproduce

  1. launch Nightly (1.25.10 Chromium: 90.0.4430.61 used in this case)
  2. visit either 1-1ads.com, actionsplash.com or pub.chez.com
  3. you'll notice that the interstitial page is being displayed which means top level domain blocking is occurring

Actual result:

Top level domain blocking is occurring even when Standard is selected as the default shields setting.

Expected result:

Top level domain blocking should be disabled on Standard and only enabled when a user has selected Aggressive mode.

Reproduces how often:

100% reproducible using the above STR.

Brave version (brave://version info)

Brave | 1.25.10 Chromium: 90.0.4430.61 (Official Build) nightly (64-bit)
-- | --
Revision | dced74d4124b26b14126b611853d33512b60c7b6-refs/branch-heads/4430@{#1115}
OS | Windows 10 OS Version 2009 (Build 19042.906)

Version/Channel Information:

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? N/A
  • Does the issue resolve itself when disabling Brave Rewards? N/A
  • Is the issue reproducible on the latest version of Chrome? N/A

Miscellaneous Information:

CCing @rebron @bsclifton @brave/legacy_qa @pes10k @pilgrim-brave

@stephendonner
Copy link

stephendonner commented Apr 15, 2021

Verified PASSED using

Brave 1.24.65 Chromium: 90.0.4430.72 (Official Build) dev (x86_64)
Revision b6172ef8d07ef486489a4b11b66b2eaeed50d132-refs/branch-heads/4430@{#1233}
OS macOS Version 11.2.3 (Build 20D91)

Steps:

  1. launched Brave
  2. loaded 1-1ads.com1, actionsplash.com, pub.chez.com with default Shields setting Trackers & ads blocked (standard)
  3. confirmed I was able to load (or at least DNS-lookup, in the case of 1-1ads.com) the sites without seeing the interstitial/blocking page, for each
  4. loaded 1-1ads.com1, actionsplash.com, pub.chez.com aggressive-mode Shields setting Trackers & ads blocked (aggressive)
  5. confirmed I got the interstitial blocked page, for each
example example example example example example
Screen Shot 2021-04-15 at 12 15 58 PM actionsplash.com pub.chez.com Screen Shot 2021-04-15 at 12 19 41 PM Screen Shot 2021-04-15 at 12 15 34 PM pub.chez.com (blocked)

Verification passed on

Brave 1.24.66 Chromium: 90.0.4430.72 (Official Build) beta (64-bit)
Revision b6172ef8d07ef486489a4b11b66b2eaeed50d132-refs/branch-heads/4430@{#1233}
OS Ubuntu 18.04 LTS

Verified for default Shields setting Trackers & ads blocked (standard)

image image image

Verified for aggressive-mode Shields setting Trackers & ads blocked (aggressive)

image image image

Verification passed on

Brave | 1.24.69 Chromium: 90.0.4430.72 (Official Build) dev (64-bit)
-- | --
Revision | b6172ef8d07ef486489a4b11b66b2eaeed50d132-refs/branch-heads/4430@{#1233}
OS | Windows 10 OS Version 2004 (Build 19041.928)

Verified for default Shields setting Trackers & ads blocked (standard)

image image image

Verified for aggressive-mode Shields setting Trackers & ads blocked (aggressive)

image image image

@stephendonner
Copy link

stephendonner commented Apr 29, 2021

Verified PASSED on Android 9 using Brave 1.24.76, Chromium 90.0.4430.85, Google Pixel, arm64.

Confirmed that loading 1-1ads.com, actionsplash.com and pub.chez.com with Shields' defaults (since no aggressive mode yet on Android) didn't load the interstitial blocking page.

example example example
Screenshot (Apr 29, 2021 10_57_06 AM) Screenshot (Apr 29, 2021 10_57_40 AM) Screenshot_20210429-105817

Verification passed on Samsung Tab A with Android 10 running 1.24.81 x64 build

  • Verified with brave://flags/#brave-domain-block set to default and shields set to default page loads correctly and no interstitial page is shown
  • Verified enabling brave://flags/#brave-domain-block doesn't show interstitial page instead loads the page correctly
1-1ads.com pub-chez.com actionsplash.com
image image image

@LaurenWags
Copy link
Member

changing to release-notes/exclude per discussion with @rebron and @kjozwiak

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug feature/shields The overall Shields feature in Brave. OS/Android Fixes related to Android browser functionality OS/Desktop privacy/feature User-facing privacy- & security-focused feature work. privacy-pod Feature work for the Privacy & Web Compatibility pod QA Pass - Android ARM QA Pass - Android Tab QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-All-Platforms QA/Yes release-notes/exclude
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants