Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fingerprint global settings are overwritten on startup #1524

Closed
srirambv opened this issue Oct 11, 2018 · 2 comments · Fixed by brave/brave-core#622
Closed

Fingerprint global settings are overwritten on startup #1524

srirambv opened this issue Oct 11, 2018 · 2 comments · Fixed by brave/brave-core#622
Assignees
Labels

Comments

@srirambv
Copy link
Contributor

srirambv commented Oct 11, 2018

See also:
#1592

Description

While verifying #1364 found Fingerprint settings are not retained across session

Steps to Reproduce

  1. Clean profile on 0.55.12
  2. Change default shields settings to different value
  3. Restart browser, Fingerprint setting gets reset to default value
  4. Change default shield settings and visit a site in a new tab
  5. Restart browser, fingerprint setting still gets reset to default value

Actual result:

1364

Expected result:

All shields settings which are changed at global setting should be retained across session

Reproduces how often:

Easy

Brave version (chrome://version info)

Brave 0.55.12 Chromium: 70.0.3538.45 (Official Build) beta (64-bit)
Revision cbdc32e4334458954e9def214d7e5fa1ca1960eb-refs/branch-heads/3538@{#830}
OS Linux

Reproducible on current release:

  • Does it reproduce on brave-browser dev/beta builds? Yes on Beta. Need to test on new Dev
  • Does it reproduce on browser-laptop? No

Website problems only:

  • Does the issue resolve itself when disabling Brave Shields?
  • Is the issue reproducible on the latest version of Chrome?

Additional Information

@srirambv srirambv added bug feature/shields The overall Shields feature in Brave. release/blocking feature/global-settings Settings at browser level independent of shields settings QA/Yes QA/Test-Plan-Specified labels Oct 11, 2018
@srirambv srirambv added this to the 0.55.x milestone Oct 11, 2018
@bbondy bbondy assigned pilgrim-brave and unassigned bbondy and simonhong Oct 12, 2018
@bbondy
Copy link
Member

bbondy commented Oct 12, 2018

@yrliou noticed that likely on startup we overwrite the global shield setting, so I think work @pilgrim-brave is doing in #1449 will fix this.

@bbondy bbondy changed the title Cookie and Fingerprint settings are not retained across session Cookie and Fingerprint global settings are overwritten on startup Oct 15, 2018
@bbondy bbondy changed the title Cookie and Fingerprint global settings are overwritten on startup Fingerprint global settings are overwritten on startup Oct 15, 2018
@srirambv
Copy link
Contributor Author

srirambv commented Oct 17, 2018

Verification Passed on

Brave 0.55.16 Chromium: 70.0.3538.54 (Official Build) (64-bit)
Revision 4f8e578b6680574714e9ed3bb9f02922b4dde40d-refs/branch-heads/3538@{#937}
OS Linux
  • Verified changing Fingerprint settings globally is retained at startup

Verification Passed on

Brave 0.55.16 Chromium: 70.0.3538.54 (Official Build) (64-bit)
Revision 4f8e578b6680574714e9ed3bb9f02922b4dde40d-refs/branch-heads/3538@{#937}
OS Windows
  • Verified changing Fingerprint settings globally is retained at startup

Verified passed with

Brave 0.55.17 Chromium: 70.0.3538.67 (Official Build) (64-bit)
Revision 9ab0cfab84ded083718d3a4ff830726efd38869f-refs/branch-heads/3538@{#1002}
OS Mac OS X
  • Verified changing Fingerprint settings globally is retained at startup

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants