Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow the end user to move/reposition custom ad notifications #14813

Closed
tmancey opened this issue Mar 18, 2021 · 2 comments
Closed

Allow the end user to move/reposition custom ad notifications #14813

tmancey opened this issue Mar 18, 2021 · 2 comments

Comments

@tmancey
Copy link
Contributor

tmancey commented Mar 18, 2021

No description provided.

@tmancey tmancey self-assigned this Mar 18, 2021
@tmancey tmancey added this to the 1.26.x - Nightly milestone Apr 29, 2021
@tmancey
Copy link
Contributor Author

tmancey commented Apr 29, 2021

Resolved as part of #13132, please test as part of the new custom ad notifications

@btlechowski
Copy link

btlechowski commented Jun 3, 2021

Verification passed on

Brave 1.26.50 Chromium: 91.0.4472.77 (Official Build) beta (64-bit)
Revision 1cecd5c8a856bc2a5adda436e7b84d8d21b339b6-refs/branch-heads/4472@{#1246}
OS Ubuntu 18.04 LTS

Verified able to move the custom ad notification
image
Verified the position is retained for the next ad, even after browser restart
image

Verified the custom ad notification respects System UI
14813

Verified the custom ad notification responds to System UI changes
14813_2


Verified PASSED using

Brave 1.26.50 Chromium: 91.0.4472.77 (Official Build) beta (x86_64)
Revision 1cecd5c8a856bc2a5adda436e7b84d8d21b339b6-refs/branch-heads/4472@{#1246}
OS macOS Version 11.4 (Build 20F71)

Verified able to move the custom ad notification
image

Verified the position is retained for the next ad, even after browser restart
image

Verified the custom ad notification respects System UI
ads-reposition

Verified the custom ad notification responds to System UI changes
ads-resizing


Verification passed on



<!--StartFragment-->
Brave | 1.26.50 Chromium: 91.0.4472.77&nbsp;(Official Build)&nbsp;beta&nbsp;(64-bit)
-- | --
Revision | 1cecd5c8a856bc2a5adda436e7b84d8d21b339b6-refs/branch-heads/4472@{#1246}
OS | Windows&nbsp;10 OS Version 2004 (Build 19041.985)

<!--EndFragment-->

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

No branches or pull requests

4 participants