Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NTP Rewards widget should not enable AC for users that have turned AC off #14735

Closed
zenparsing opened this issue Mar 15, 2021 · 1 comment · Fixed by brave/brave-core#8273
Closed

NTP Rewards widget should not enable AC for users that have turned AC off #14735

zenparsing opened this issue Mar 15, 2021 · 1 comment · Fixed by brave/brave-core#8273
Assignees
@zenparsing
Labels
feature/rewards OS/Desktop QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-All-Platforms QA/Yes release-notes/include
Milestone
1.24.x - Release

Comments

@zenparsing
Copy link

Description

Currently, the NTP rewards widget will show an onboarding CTA if the user has not enabled ads, or if the user has disabled Ads. When the user clicks the button, both Ads and AC are enabled. This can lead to confusion for users that have explicitly disabled AC in the past.

Steps to Reproduce

  1. Start the browser with a clean profile
  2. Navigate to brave://rewards and click "Start using Rewards".
  3. Disable AC.
  4. Disable Ads
  5. Open a new tab
  6. On the NTP, click the "Start using Rewards" button
  7. Navigate to brave://rewards

Actual result:

AC is enabled.

Expected result:

AC is not enabled.
@zenparsing zenparsing self-assigned this Mar 16, 2021
@zenparsing zenparsing mentioned this issue Mar 17, 2021
Merged
24 tasks
@zenparsing zenparsing added this to the 1.24.x - Nightly milestone Apr 2, 2021
@LaurenWags LaurenWags added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Apr 5, 2021
@LaurenWags
Copy link
Member

LaurenWags commented Apr 5, 2021 •
edited by GeetaSarvadnya
Loading

Verified passed with

Brave	1.24.46 Chromium: 90.0.4430.41 (Official Build) nightly (x86_64)
Revision	e9c92b1eaca8487e212f3f6bc081fdb6d4863759-refs/branch-heads/4430@{#723}
OS	macOS Version 10.15.7 (Build 19H524)

Verified test plan from brave/brave-core#8273 (comment)

Scenario 1 - Existing user, no Uphold

Installed 1.24.46 using staging env.
Enabled Rewards from panel.
Navigated to brave://rewards and disabled both Ads and AC.
Opened NTP.
Clicked "Start Using Rewards" from Rewards widget.
Navigated to brave://rewards.
Confirmed only Ads enabled, AC not enabled.
Closed/relaunched browser.
Confirmed still only Ads enabled, AC not enabled.

Scenario 2 - Existing user with Uphold

Installed 1.24.46 using staging env.
Enabled Rewards from NTP.
Connected KYC'd Uphold wallet.
Disable both Ads and AC.
Opened NTP.
Clicked "Start Using Rewards" from Rewards widget.
Navigated to brave://rewards.
Confirmed only Ads enabled, AC not enabled.
Closed/relaunched browser.
Confirmed still only Ads enabled, AC not enabled.

Scenario 3 - Upgrade profile with non-zero balance, no Uphold

Install 1.23.x using staging env.
Enable Rewards from panel.
Claim UGP grant.
Navigate to brave://rewards and disable both Ads and AC.
Confirm NTP offers to "Start using Rewards".
Close 1.23.x.
"Upgrade" to 1.24.x (renamed profile folder, launch with 1.24.x).
Open NTP, select "Start using Rewards" from widget.
Navigate to brave://rewards.
Confirm only Ads enabled, not AC.
Closed/relaunched browser.
Confirmed still only Ads enabled, AC not enabled.

Scenario 4 - Upgrade profile with non-zero balance with Uphold

Install 1.23.x using staging env.
Enable Rewards from panel.
Connect KYC'd Uphold wallet.
Navigate to brave://rewards and disable both Ads and AC.
Confirm NTP offers to "Start using Rewards".
Close 1.23.x.
"Upgrade" to 1.24.x (renamed profile folder, launch with 1.24.x).
Open NTP, select "Start using Rewards" from widget.
Navigate to brave://rewards.
Confirm only Ads enabled, not AC.
Closed/relaunched browser.
Confirmed still only Ads enabled, AC not enabled.

Scenario 5 - Upgrade profile with zero balance, no Uphold

Install 1.23.x using staging env.
Enable Rewards from panel.
Do not claim UGP grant.
Navigate to brave://rewards and disable both Ads and AC.
Confirm NTP offers to "Start using Rewards".
Close 1.23.x.
"Upgrade" to 1.24.x (renamed profile folder, launch with 1.24.x).
Open NTP, select "Start using Rewards" from widget.
Navigate to brave://rewards.
Confirm both Ads and AC enabled as per brave/brave-core#8273 (comment).
Closed/relaunched browser.
Confirmed both Ads and AC enabled.

Scenario 6 - Upgrade profile with zero balance with Uphold

Install 1.23.x using staging env.
Enable Rewards from panel.
Connect KYC'd Uphold wallet that has zero BAT in Brave Browser card.
Navigate to brave://rewards and disable both Ads and AC.
Confirm NTP offers to "Start using Rewards".
Close 1.23.x.
"Upgrade" to 1.24.x (renamed profile folder, launch with 1.24.x).
Open NTP, select "Start using Rewards" from widget.
Navigate to brave://rewards.
Confirm both Ads and AC enabled as per brave/brave-core#8273 (comment).
Closed/relaunched browser.
Confirmed both Ads and AC enabled.

Verification passed on

Brave 1.24.66 Chromium: 90.0.4430.72 (Official Build) beta (64-bit)
Revision b6172ef8d07ef486489a4b11b66b2eaeed50d132-refs/branch-heads/4430@{#1233}
OS Ubuntu 18.04 LTS

Verified test plan from brave/brave-core#8273 (comment)

Scenario 1 - Existing user, no Uphold

Installed 1.24.46 using staging env.
Enabled Rewards from panel.
Navigated to brave://rewards and disabled both Ads and AC.
Opened NTP.
Clicked "Start Using Rewards" from Rewards widget.
Navigated to brave://rewards.
Confirmed only Ads enabled, AC not enabled.
Closed/relaunched browser.
Confirmed still only Ads enabled, AC not enabled.

Scenario 2 - Existing user with Uphold

Installed 1.24.46 using staging env.
Enabled Rewards from NTP.
Connected KYC'd Uphold wallet.
Disable both Ads and AC.
Opened NTP.
Clicked "Start Using Rewards" from Rewards widget.
Navigated to brave://rewards.
Confirmed only Ads enabled, AC not enabled.
Closed/relaunched browser.
Confirmed still only Ads enabled, AC not enabled.

Scenario 3 - Upgrade profile with non-zero balance, no Uphold

Install 1.23.x using staging env.
Enable Rewards from panel.
Claim UGP grant.
Navigate to brave://rewards and disable both Ads and AC.
Confirm NTP offers to "Start using Rewards".
Close 1.23.x.
"Upgrade" to 1.24.x (renamed profile folder, launch with 1.24.x).
Open NTP, select "Start using Rewards" from widget.
Navigate to brave://rewards.
Confirm only Ads enabled, not AC.
Closed/relaunched browser.
Confirmed still only Ads enabled, AC not enabled.

Scenario 4 - Upgrade profile with non-zero balance with Uphold

Install 1.23.x using staging env.
Enable Rewards from panel.
Connect KYC'd Uphold wallet.
Navigate to brave://rewards and disable both Ads and AC.
Confirm NTP offers to "Start using Rewards".
Close 1.23.x.
"Upgrade" to 1.24.x (renamed profile folder, launch with 1.24.x).
Open NTP, select "Start using Rewards" from widget.
Navigate to brave://rewards.
Confirm only Ads enabled, not AC.
Closed/relaunched browser.
Confirmed still only Ads enabled, AC not enabled.

Scenario 5 - Upgrade profile with zero balance, no Uphold

Install 1.23.x using staging env.
Enable Rewards from panel.
Do not claim UGP grant.
Navigate to brave://rewards and disable both Ads and AC.
Confirm NTP offers to "Start using Rewards".
Close 1.23.x.
"Upgrade" to 1.24.x (renamed profile folder, launch with 1.24.x).
Open NTP, select "Start using Rewards" from widget.
Navigate to brave://rewards.
Confirm both Ads and AC enabled as per brave/brave-core#8273 (comment).
Closed/relaunched browser.
Confirmed both Ads and AC enabled.

Scenario 6 - Upgrade profile with zero balance with Uphold

Install 1.23.x using staging env.
Enable Rewards from panel.
Connect KYC'd Uphold wallet that has zero BAT in Brave Browser card.
Navigate to brave://rewards and disable both Ads and AC.
Confirm NTP offers to "Start using Rewards".
Close 1.23.x.
"Upgrade" to 1.24.x (renamed profile folder, launch with 1.24.x).
Open NTP, select "Start using Rewards" from widget.
Navigate to brave://rewards.
Confirm both Ads and AC enabled as per brave/brave-core#8273 (comment).
Closed/relaunched browser.
Confirmed both Ads and AC enabled.

-------

Verification passed on


Brave | 1.24.69 Chromium: 90.0.4430.72 (Official Build) dev (64-bit)
-- | --
Revision | b6172ef8d07ef486489a4b11b66b2eaeed50d132-refs/branch-heads/4430@{#1233}
OS | Windows 10 OS Version 2004 (Build 19041.928)

Verified test plan from brave/brave-core#8273 (comment)

Scenario 1 - Existing user, no Uphold

Installed 1.24.46 using staging env.
Enabled Rewards from panel.
Navigated to brave://rewards and disabled both Ads and AC.
Opened NTP.
Clicked "Start Using Rewards" from Rewards widget.
Navigated to brave://rewards.
Confirmed only Ads enabled, AC not enabled.
Closed/relaunched browser.
Confirmed still only Ads enabled, AC not enabled.

Scenario 2 - Existing user with Uphold

Installed 1.24.46 using staging env.
Enabled Rewards from NTP.
Connected KYC'd Uphold wallet.
Disable both Ads and AC.
Opened NTP.
Clicked "Start Using Rewards" from Rewards widget.
Navigated to brave://rewards.
Confirmed only Ads enabled, AC not enabled.
Closed/relaunched browser.
Confirmed still only Ads enabled, AC not enabled.

Scenario 3 - Upgrade profile with non-zero balance, no Uphold

Install 1.23.x using staging env.
Enable Rewards from panel.
Claim UGP grant.
Navigate to brave://rewards and disable both Ads and AC.
Confirm NTP offers to "Start using Rewards".
Close 1.23.x.
"Upgrade" to 1.24.x (renamed profile folder, launch with 1.24.x).
Open NTP, select "Start using Rewards" from widget.
Navigate to brave://rewards.
Confirm only Ads enabled, not AC.
Closed/relaunched browser.
Confirmed still only Ads enabled, AC not enabled.

Scenario 4 - Upgrade profile with non-zero balance with Uphold

Install 1.23.x using staging env.
Enable Rewards from panel.
Connect KYC'd Uphold wallet.
Navigate to brave://rewards and disable both Ads and AC.
Confirm NTP offers to "Start using Rewards".
Close 1.23.x.
"Upgrade" to 1.24.x (renamed profile folder, launch with 1.24.x).
Open NTP, select "Start using Rewards" from widget.
Navigate to brave://rewards.
Confirm only Ads enabled, not AC.
Closed/relaunched browser.
Confirmed still only Ads enabled, AC not enabled.

Scenario 5 - Upgrade profile with zero balance, no Uphold

Install 1.23.x using staging env.
Enable Rewards from panel.
Do not claim UGP grant.
Navigate to brave://rewards and disable both Ads and AC.
Confirm NTP offers to "Start using Rewards".
Close 1.23.x.
"Upgrade" to 1.24.x (renamed profile folder, launch with 1.24.x).
Open NTP, select "Start using Rewards" from widget.
Navigate to brave://rewards.
Confirm both Ads and AC enabled as per brave/brave-core#8273 (comment). (need brave://rewards page reload to see AC enabled)
Closed/relaunched browser.
Confirmed both Ads and AC enabled.

Scenario 6 - Upgrade profile with zero balance with Uphold

Install 1.23.x using staging env.
Enable Rewards from panel.
Connect KYC'd Uphold wallet that has zero BAT in Brave Browser card.
Navigate to brave://rewards and disable both Ads and AC.
Confirm NTP offers to "Start using Rewards".
Close 1.23.x.
"Upgrade" to 1.24.x (renamed profile folder, launch with 1.24.x).
Open NTP, select "Start using Rewards" from widget.
Navigate to brave://rewards.
Confirm both Ads and AC enabled as per brave/brave-core#8273 (comment). (need brave://rewards page reload to see AC enabled)
Closed/relaunched browser.
Confirmed both Ads and AC enabled.

@LaurenWags LaurenWags added QA Pass-macOS and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Apr 5, 2021
@LaurenWags LaurenWags mentioned this issue May 4, 2021
Closed
@stephendonner stephendonner mentioned this issue May 7, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zenparsing zenparsing

Labels
feature/rewards OS/Desktop QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-All-Platforms QA/Yes release-notes/include
Projects
None yet
Milestone
1.24.x - Release
Development

Successfully merging a pull request may close this issue.

Use rewards enabled pref to track opt-in status brave/brave-core
4 participants
@zenparsing @LaurenWags @btlechowski @GeetaSarvadnya