Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Hide Brave Rewards" toggle doesn't work after using Private window #14531

Closed
emerick opened this issue Mar 6, 2021 · 2 comments · Fixed by brave/brave-core#8335
Closed

"Hide Brave Rewards" toggle doesn't work after using Private window #14531

emerick opened this issue Mar 6, 2021 · 2 comments · Fixed by brave/brave-core#8335

Comments

@emerick
Copy link
Contributor

emerick commented Mar 6, 2021

@iefremov reported the following:

I've installed fresh beta and it seems "Hide Brave Rewards toggle" is by default on, while the icon is shown

image

@bsclifton bsclifton changed the title "Hide Brave Rewards" is enabled but Rewards icon not shown on fresh install "Hide Brave Rewards" is enabled on fresh install (Rewards icon is shown in omnibox) Mar 8, 2021
@iefremov
Copy link
Contributor

iefremov commented Mar 8, 2021

STR:

  1. fresh install
  2. open chrome://settings, toggle "Hide Brave Rewards Toggle" -> it hides the rewards icon as expected
  3. open an incognito window
  4. repeat step (2) -> toggling the switch has no effect
  5. close an incognito window
  6. repeat step (2) -> toggling the switch has no effect
kazam_xlc4vv0q.movie.mp4

@emerick emerick changed the title "Hide Brave Rewards" is enabled on fresh install (Rewards icon is shown in omnibox) "Hide Brave Rewards" toggle doesn't work after using Incognito window Mar 8, 2021
@emerick emerick changed the title "Hide Brave Rewards" toggle doesn't work after using Incognito window "Hide Brave Rewards" toggle doesn't work after using Private window Mar 8, 2021
@emerick emerick removed the OS/Linux label Mar 8, 2021
@emerick emerick self-assigned this Mar 23, 2021
@emerick emerick added this to the 1.24.x - Nightly milestone Mar 25, 2021
@stephendonner
Copy link

stephendonner commented Mar 26, 2021

Verified PASSED using latest nightly build and the inline testplan.

First, made sure I could reproduce the bug, using

Brave 1.23.53 Chromium: 89.0.4389.105 (Official Build) beta (x86_64)
Revision 14f44e21a9d539cd49c72468a29bfca4fa43f710-refs/branch-heads/4389_90@{#7}
OS macOS Version 11.2.3 (Build 20D91)
mini screencast

Then, verified, using

Brave 1.24.29 Chromium: 90.0.4430.41 (Official Build) nightly (x86_64)
Revision e9c92b1eaca8487e212f3f6bc081fdb6d4863759-refs/branch-heads/4430@{#723}
OS macOS Version 11.2.3 (Build 20D91)

rewards-toggle-fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment