Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Tor" label on private windows with Tor #1384

Closed
tildelowengrimm opened this issue Oct 1, 2018 · 3 comments · Fixed by brave/brave-core#547
Closed

"Tor" label on private windows with Tor #1384

tildelowengrimm opened this issue Oct 1, 2018 · 3 comments · Fixed by brave/brave-core#547
Assignees
@petemill
Labels
feature/tor QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-Plan-Specified QA/Yes
Milestone
0.55.x - Release ...

Comments

@tildelowengrimm
Copy link
Contributor

Instead of the people menu or the incognito hat-and-glasses, Tor windows should have the same simple "Tor" label as Muon tabs with Tor.
@bbondy
Copy link
Member

bbondy commented Oct 2, 2018

Could you take a screenshot of what you mean?

@petemill petemill assigned petemill and unassigned darkdh and riastradh-brave Oct 2, 2018
@petemill petemill mentioned this issue Oct 2, 2018
Merged
11 tasks
petemill added a commit to brave/brave-core that referenced this issue Oct 2, 2018
@petemill
Toolbar Tor profile icon
0084030 
Fix brave/brave-browser#1384
@petemill
Copy link
Member

petemill commented Oct 2, 2018

Test plan on PR brave/brave-core#547

This was referenced Oct 2, 2018
Closed
Closed
@btlechowski
Copy link

btlechowski commented Oct 10, 2018 •
edited by srirambv
Loading

Verification passed on

Brave 0.55.12 Chromium: 70.0.3538.45 (Official Build) (64-bit)
Revision cbdc32e4334458954e9def214d7e5fa1ca1960eb-refs/branch-heads/3538@{#830}
OS Windows 7

image

Verified passed with

Brave 0.55.12 Chromium: 70.0.3538.45 (Official Build) beta(64-bit)
Revision cbdc32e4334458954e9def214d7e5fa1ca1960eb-refs/branch-heads/3538@{#830}
OS Mac OS X

Verification Passed on

Brave 0.55.12 Chromium: 70.0.3538.45 (Official Build) beta (64-bit)
Revision cbdc32e4334458954e9def214d7e5fa1ca1960eb-refs/branch-heads/3538@{#830}
OS Linux

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@petemill petemill

Labels
feature/tor QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-Plan-Specified QA/Yes
Projects
None yet
Milestone
0.55.x - Release (Release Channel)
Development

Successfully merging a pull request may close this issue.

Toolbar Tor profile icon brave/brave-core
9 participants
@tildelowengrimm @petemill @bbondy @bsclifton @darkdh @srirambv @LaurenWags @riastradh-brave @btlechowski