Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

List PeerID and AgentVersion in brave://ipfs #13839

Closed
bbondy opened this issue Jan 29, 2021 · 1 comment · Fixed by brave/brave-core#7759
Closed

List PeerID and AgentVersion in brave://ipfs #13839

bbondy opened this issue Jan 29, 2021 · 1 comment · Fixed by brave/brave-core#7759

Comments

@bbondy
Copy link
Member

bbondy commented Jan 29, 2021

Per Lidel, it would be useful to list the PeerID and AgentVersion from the API.
https://docs.ipfs.io/reference/http/api/#api-v0-id

PeerID is ID from there

@bbondy bbondy added priority/P3 The next thing for us to work on. It'll ride the trains. OS/Desktop labels Jan 29, 2021
@bbondy bbondy changed the title List PeerID and AgentVersion in chrome://ipfs List PeerID and AgentVersion in brave://ipfs Jan 29, 2021
@spylogsster spylogsster self-assigned this Feb 1, 2021
@bbondy bbondy added this to the 1.21.x - Nightly milestone Feb 1, 2021
@stephendonner
Copy link

stephendonner commented Feb 11, 2021

Verified FIXED using

Brave 1.21.51 Chromium: 88.0.4324.152 (Official Build) beta (x86_64)
Revision 6579930fc53b4dc589c042bec9d0a3778326974d-refs/branch-heads/4324@{#2106}
OS macOS Version 11.2.1 (Build 20D74)

Steps to verify:

  1. Loaded ipfs://bafybeiemxf5abjwjbikoz4mc3a3dla6ual3jsgpdr4cjr3oz3evfyavhwq/wiki/Vincent_van_Gogh.html to trigger IPFS-support detection
  2. Clicked "Enable IPFS" as instructed
  3. Loaded brave://ipfs
  4. Verified that both PeerID and Version were present, with sane values, under "Node info"

Screen Shot 2021-02-12 at 11 22 18 AM


Verification passed on

Brave 1.21.52 Chromium: 88.0.4324.152 (Official Build) dev (64-bit)
Revision 6579930fc53b4dc589c042bec9d0a3778326974d-refs/branch-heads/4324@{#2106}
OS Ubuntu 18.04 LTS

Verified the above test plan
Verified that both PeerID and Version were present, with sane values, under "Node info"
image


Verification passed on


Brave | 1.21.56 Chromium: 88.0.4324.152 (Official Build) dev (64-bit)
-- | --
Revision | 6579930fc53b4dc589c042bec9d0a3778326974d-refs/branch-heads/4324@{#2106}
OS | Windows 10 OS Version 2004 (Build 19041.804)


Verified the above test plan
Verified that both PeerID and Version were present, with sane values, under "Node info"

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants