Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix race condition in Brave Rewards panel that results in inconsistent UI ("Your wallet" vs verify wallet) #13801

Closed
Miyayes opened this issue Jan 27, 2021 · 2 comments · Fixed by brave/brave-core#8113

Comments

@Miyayes
Copy link
Collaborator

Miyayes commented Jan 27, 2021

Description

In the Brave Rewards dropdown panel, sometimes the panel will display "Your wallet" text, and sometimes it will display "Verify wallet" (or "Wallet verified"). It is inconsistent, and according to some investigation, is due to a race condition in the code.

In no case should it show the "Your wallet" text. The panel should always show "Verify wallet" (or "Verified wallet" if the user is already verified). The "Your wallet" text should be removed, and the race condition should be fixed.

Your wallet case (incorrect):
image

Verify wallet case (correct):
image

Steps to Reproduce

  1. Open the Brave Rewards panel
  2. Observe that sometimes it shows one or the other

Reproduces how often:

Depends on race condition.

Version

Happens as late as v1.19.

@Miyayes Miyayes added OS/Android Fixes related to Android browser functionality OS/Desktop feature/rewards labels Jan 27, 2021
@emerick
Copy link
Contributor

emerick commented Feb 18, 2021

The onboarding modal is also not displayed when this occurs.

@emerick emerick added this to the 1.23.x - Nightly milestone Mar 3, 2021
@LaurenWags LaurenWags added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Mar 9, 2021
@LaurenWags
Copy link
Member

Verified passed with

Brave | 1.23.25 Chromium: 89.0.4389.86 (Official Build) nightly (x86_64)
-- | --
Revision | 0c2dac31bc21e806a791641316e99920f84ea52c-refs/branch-heads/4389@{#1472}
OS | macOS Version 10.15.7 (Build 19H524)

Verified test plan from brave/brave-core#8113.
Verified STR from description.
Tried test plan steps ~15x to reproduce the issue using 1.21.74 and was unable to reproduce.
Tried test plan steps ~15x on 1.23.x and did not see the race condition.

@LaurenWags LaurenWags added QA Pass-macOS and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Mar 9, 2021
@emerick emerick removed the OS/Android Fixes related to Android browser functionality label Apr 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment