IPFS with local node has Shields UI not available

[bbondy]

Description

Clicking on the Brave shields when loading a top level IPFS URI does nothing. It also shows up as disabled.

Steps to Reproduce

First add an HTML file that prints to the console.log in your IPFS instance:

cd ~/Library/Application Support/BraveSoftware/Brave-Browser-Development/nljcddpbnaianmglkpkneakjaapinabi/1.0.3

./go-ipfs_v0.7.0_darwin-amd64 --api=/ip4/127.0.0.1/tcp/45002 add test.html

Where test.html is:

<script>
  console.log('hello this is a test')
</script>

Check your dev console, right click inspect page, then look on the JS console.

Note your API may differ if you're not using Nightly, just go to chrome://ipfs to see the API port of your install. Each channel is different.

1. Setup Brave to use an IPFS local node
2. Navigate to ipfs://QmUoGhtHGFExwC3Amd8tqYD7T6LczSRchpRe5wPwtaXodC (Note the output of the add command above might have given a different CID If you have an extra space or anything like that in your file)
3. Check your console and it should have some text
4. Turn on script blocking, and on the next reload the console should not display anything
5. Turn off global shields and the script blocking should display again

Actual result:

Shields panel is always disabled

Expected result:

Shields panel should be enabled.

Reproduces how often: Always

Brave version (brave://version info)

1.21.x and below (all versions up until it is fixed)

Version/Channel Information:

• Can you reproduce this issue with the current release? yes
• Can you reproduce this issue with the beta channel? yes
• Can you reproduce this issue with the nightly channel? yes

[stephendonner]

Verified FIXED using the inline test plan here, with

Brave	1.21.55 Chromium: 88.0.4324.152 (Official Build) beta (x86_64)
Revision	6579930fc53b4dc589c042bec9d0a3778326974d-refs/branch-heads/4324@{#2106}
OS	macOS Version 11.2.1 (Build 20D74)

1. Setup Brave to use an IPFS local node

2. Navigate to ipfs://QmUoGhtHGFExwC3Amd8tqYD7T6LczSRchpRe5wPwtaXodC (Note the output of the add command above might have given a different CID If you have an extra space or anything like that in your file)
3. Check your console and it should have some text

4. Turn on script blocking, and on the next reload the console should not display anything

5. Turn off global shields and the script blocking should display again

---

Verification passed on

Brave | 1.21.63 Chromium: 88.0.4324.182 (Official Build) dev (64-bit)
-- | --
Revision | 73ee5087001dcef33047c4ed650471b225dd8caf-refs/branch-heads/4324@{#2202}
OS | Windows 10 OS Version 2004 (Build 19041.804)

• Verified the test plan mentioned in the description

Setup Brave to use an IPFS local node

c:\Users\DELL\AppData\Local\BraveSoftware\Brave-Browser-Dev\User Data\lnbclahgobmjphilkalbhebakmblnbij\1.0.3>go-ipfs_v0.7.0_windows-amd64 --api="/ip4/127.0.0.1/tcp/45003" add test.html
 140 B / ? [--------------------------------------------------------=-------------------------------------------------------------------------------------------------------------------------------------------] ←added QmTXEwXKTM45SLKNbt4BLX8fXn1uzicnfxGGPmmnPFJNyo test.html
 140 B / 140 B [=========================================================================================================================================================================================] 100.00%
c:\Users\DELL\AppData\Local\BraveSoftware\Brave-Browser-Dev\User Data\lnbclahgobmjphilkalbhebakmblnbij\1.0.3>

Navigate to ipfs://QmTXEwXKTM45SLKNbt4BLX8fXn1uzicnfxGGPmmnPFJNyo and ensured console has some text

Enable script blocking and ensured nothing is displayed in the console

Turn off global shield settings and ensured script blocking is displayed again

---

Verification passed on

Brave	1.21.64 Chromium: 88.0.4324.182 (Official Build) beta (64-bit)
Revision	73ee5087001dcef33047c4ed650471b225dd8caf-refs/branch-heads/4324@{#2202}
OS	Ubuntu 18.04 LTS

• Verified the test plan mentioned in the description

Setup Brave to use an IPFS local node

bartlomiej@bartlomiej-VirtualBox:~/.config/BraveSoftware/Brave-Browser-Beta/oecghfpdmkjlhnfpmmjegjacfimiafjp/1.0.3$ ./go-ipfs_v0.7.0_linux-amd64 --api=/ip4/127.0.0.1/tcp/45004 add test.html
added QmUoGhtHGFExwC3Amd8tqYD7T6LczSRchpRe5wPwtaXodC test.html
 137 B / ? [------------------------------------------------------------------------------------------------------------------------=-------] 
bartlomiej@bartlomiej-VirtualBox:~/.config/BraveSoftware/Brave-Browser-Beta/oecghfpdmkjlhnfpmmjegjacfimiafjp/1.0.3$ 

Navigate to ipfs://QmUoGhtHGFExwC3Amd8tqYD7T6LczSRchpRe5wPwtaXodC and ensured console has some text

Enable script blocking and ensured nothing is displayed in the console

Turn off global shield settings and ensured script blocking is displayed again