Public content settings are not inherited by private window #1373
Labels
bug
feature/private-browsing
feature/shields
The overall Shields feature in Brave.
priority/P4
Planned work. We expect to get to it "soon".
QA Pass-Linux
QA Pass-macOS
QA Pass-Win64
QA/Yes
release-notes/include
Milestone
Description
Public content settings are not inherited by private window. I believe these values are initialized with https://github.com/brave/brave-core/blob/master/components/content_settings/core/browser/brave_host_content_settings_map.cc, but because the extension has it's
incognito
property set tosplit
, it may not be able to directly access theregular
scoped content_settings. More investigation is neededProblem was exposed when fixing #1198
Per #1721 - if no public settings exist for a given site, private window should inherit the global setting
Steps to Reproduce
Private window inheriting from existing public content setting
Private window inheriting from global settings
Actual result:
Expected result:
Shields should be DOWN in the private window... because the session content_settings should inherit from the regular content_settings
Reproduces how often:
100%
Brave version (chrome://version info)
Current master (brave/brave-core@cacede9)
The text was updated successfully, but these errors were encountered: