Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Travis CI unit tests failing on brave-core master #1370

Closed
ryanml opened this issue Oct 1, 2018 · 1 comment · Fixed by brave/brave-core#533
Closed

Travis CI unit tests failing on brave-core master #1370

ryanml opened this issue Oct 1, 2018 · 1 comment · Fixed by brave/brave-core#533
Assignees
@ryanml
Labels
QA/No QA/Test-Plan-Specified release-notes/exclude
Milestone
0.55.x - Release ...

Comments

@ryanml
Copy link
Contributor

ryanml commented Oct 1, 2018 •
edited by bsclifton
Loading

Test Plan

npm run test-unit

Description

Failing with:

screen shot 2018-10-01 at 11 10 49 am
@ryanml ryanml self-assigned this Oct 1, 2018
ryanml added a commit to ryanml/brave-core that referenced this issue Oct 1, 2018
@ryanml
Fixes brave/brave-browser#1370, adds setItem mock
c61f76e
@ryanml ryanml mentioned this issue Oct 1, 2018
Merged
11 tasks
@ryanml ryanml added this to the Releasable builds 0.55.x milestone Oct 1, 2018
@bsclifton bsclifton added the QA/No label Oct 1, 2018
@yrliou
Copy link
Member

yrliou commented Oct 1, 2018 •
edited
Loading

Put in 0.55.x milestone because tests are failing in 0.55.x and 0.56.x too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ryanml ryanml

Labels
QA/No QA/Test-Plan-Specified release-notes/exclude
Projects
None yet
Milestone
0.55.x - Release (Release Channel)
Development

Successfully merging a pull request may close this issue.

Fixing Travis unit tests ryanml/brave-core
3 participants
@yrliou @bsclifton @ryanml