Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bad merge re-disabled kVideoPlaybackQuality on 1.19.x branch. #13679

Closed
mkarolin opened this issue Jan 20, 2021 · 2 comments
Closed

Bad merge re-disabled kVideoPlaybackQuality on 1.19.x branch. #13679

mkarolin opened this issue Jan 20, 2021 · 2 comments

Comments

@mkarolin
Copy link
Contributor

kVideoPlaybackQuality was removed from disabled features list to fix #13183.

The fix was uplifted to 1.19.x branch by brave/brave-core#7451. However, a later uplift of Chromium 88 changes in brave/brave-core#7518 incorrectly reverted the change.

QA:
Please, retest with the same plan as in the original issue (#13183).

@mkarolin mkarolin self-assigned this Jan 20, 2021
mkarolin added a commit to brave/brave-core that referenced this issue Jan 20, 2021
This fixes an incorrect merge introduced by #7518 that
reverted the fix initially implemented by #7451.

Fixes brave/brave-browser#13679
@kjozwiak kjozwiak added this to the 1.19.x - Release #2 milestone Jan 20, 2021
@kjozwiak
Copy link
Member

Closing as brave/brave-core#7667 was merged into 1.19.x as per #13679 (reference).

@LaurenWags
Copy link
Member

LaurenWags commented Jan 27, 2021

Verified passed with

Brave	1.19.87 Chromium: 88.0.4324.96 (Official Build) (x86_64)
Revision	68dba2d8a0b149a1d3afac56fa74648032bcf46b-refs/branch-heads/4324@{#1784}
OS	macOS Version 10.15.7 (Build 19H15)

Verified test plan from #13183

Installed 1.18.78. Confirmed able to stream HBO Max.
Updated to 1.19.86. Reproduced unable to stream HBO Max.
Updated to 1.19.87. Confirmed able to stream HBO Max.

1.18.78 1.19.86 1.19.87
1 18 78 1 19 86 1 19 87

Also confirmed able to stream HBO Max on clean install of 1.19.87.


Verification passed on


Brave | 1.19.87 Chromium: 88.0.4324.96 (Official Build) (64-bit)
-- | --
Revision | 68dba2d8a0b149a1d3afac56fa74648032bcf46b-refs/branch-heads/4324@{#1784}
OS | Windows 10 OS Version 2004 (Build 19041.746)


Clean profile

  • ensured able to stream video on hbomax.com in 1.19.87
    image

Upgraded _profile_

Reproduced the issue in 1.19.86 - Unable to load the video and getting Uncaught (in promise) TypeError: this._htmlVideoElement.getVideoPlaybackQuality is not a function error in console
image

Upgraded the profile to 1.1987 and ensured able to stream video on hbomax.com in 1.19.87
image


Verification PASSED on Ubuntu 20.04 x64 using the following build:

Brave | 1.19.87 Chromium: 88.0.4324.96 (Official Build) (64-bit)
--- | ---
Revision | 68dba2d8a0b149a1d3afac56fa74648032bcf46b-refs/branch-heads/4324@{#1784}
OS | Linux
  • Installed 1.18.78 and ensured HBO Max was working as expected
  • Updated to 1.19.86 and reproduced the original issue re: streaming not working
  • Updated to 1.19.87 and ensured HBO Max was working as expected
  • Clean installed 1.19.87 and ensured HBO Max was working as expected
1.18.78 1.19.86 1.19.87
Screenshot from 2021-01-27 14-48-09 Screenshot from 2021-01-27 14-51-28 Screenshot from 2021-01-27 14-42-58

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment