Connections upgraded to HTTPS does not increment when HTTPS upgrades are made

[btlechowski]

Follow up from #13533, #13604

This is a regression introduced in 1.19.x. Not reproducible on 1.18.x

Steps to Reproduce

1. Clean profile
2. Run Brave and wait for the components to download
3. Open http://https-everywhere.badssl.com/
4. Open Shields

Note another URL with HTTPS upgrades that fails: http://www.cafepharma.com/

Actual result:

Connections upgraded to HTTPS does not increment when HTTPS upgrades are made
Connections upgraded to HTTPS is 0

Expected result:

Connections upgraded to HTTPS increments when HTTPS upgrades are made
Connections upgraded to HTTPS is 1

Reproduces how often:

Easily reproduced

Brave version (brave://version info)

Brave	1.19.85 Chromium: 88.0.4324.89 (Official Build) (64-bit)
Revision	4534be84786f5269fb52e9bf82643af61e2fedaf-refs/branch-heads/4324@{#1721}
OS	Ubuntu 18.04 LTS

Brave	1.20.81 Chromium: 88.0.4324.87 (Oficjalna wersja) dev (64-bitowa)
Wersja	dd01ff8f58c65af81127ad5c105c79d5b571d8f3-refs/branch-heads/4324@{#1702}
System operacyjny	Windows 7 Service Pack 1 (Build 7601.24544)

Brave	1.21.7 Chromium: 88.0.4324.87 (Oficjalna wersja) nightly (64-bitowa)
Wersja	dd01ff8f58c65af81127ad5c105c79d5b571d8f3-refs/branch-heads/4324@{#1702}
System operacyjny	Windows 7 Service Pack 1 (Build 7601.24544)

Version/Channel Information:

• Can you reproduce this issue with the current release? no (1.18.x)
• Can you reproduce this issue with the beta channel? yes
• Can you reproduce this issue with the nightly channel? yes

cc @brave/legacy_qa @fmarier @diracdeltas @iefremov @rebron

[srirambv]

Not reproducible on Android. #13533 (comment) shows HTTPS upgrade increment the value in shields

[iefremov]

We properly fire an event in BraveShieldsWebContentsObserver::DispatchBlockedEventForWebContents with blockType equal to httpUpgradableResources and the subresource is http://https-everywhere.badssl.com/

@petemill maybe we should tune something on the extension side?

[GeetaSarvadnya]

Reproduced the issue in Windows 10 x64 - 1.19.86.

Not Reproducible in 1.18.78