Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include in Auto-contribute toggle is hidden on some locales #13634

Closed
btlechowski opened this issue Jan 18, 2021 · 3 comments · Fixed by brave/brave-core#7669
Closed

Include in Auto-contribute toggle is hidden on some locales #13634

btlechowski opened this issue Jan 18, 2021 · 3 comments · Fixed by brave/brave-core#7669

Comments

@btlechowski
Copy link

This is a regression introduced in 1.18.x. Not reproducible in 1.17.x

The Include in Auto-contribute toggle is hidden in Polish (PL) locale

Steps to Reproduce

  1. Clean profile
  2. Run Brave in Polish(PL) locale
  3. Enable Rewards
  4. Open 3zsistemi.si
  5. Open Rewards Panel

Actual result:

The Include in Auto-contribute toggle is hidden
image

Expected result:

The Include in Auto-contribute toggle is shown
image

Reproduces how often:

Easily reproduced

Brave version (brave://version info)

Reproducible on

Brave 1.18.75 Chromium: 87.0.4280.101 (Official Build) (64-bit)
Revision 9407c80213cda69c2b7abcb4fa8e3f74488f4956-refs/branch-heads/4280@{#1807}
OS Ubuntu 18.04 LTS
Brave 1.19.85 Chromium: 88.0.4324.89 (Official Build) (64-bit)
Revision 4534be84786f5269fb52e9bf82643af61e2fedaf-refs/branch-heads/4324@{#1721}
OS Ubuntu 18.04 LTS
Brave 1.20.81 Chromium: 88.0.4324.87 (Oficjalna wersja) dev (64-bitowa)
Wersja dd01ff8f58c65af81127ad5c105c79d5b571d8f3-refs/branch-heads/4324@{#1702}
System operacyjny Windows 7 Service Pack 1 (Build 7601.24544)
Brave 1.21.7 Chromium: 88.0.4324.87 (Oficjalna wersja) nightly (64-bitowa)
Wersja dd01ff8f58c65af81127ad5c105c79d5b571d8f3-refs/branch-heads/4324@{#1702}
System operacyjny Windows 7 Service Pack 1 (Build 7601.24544)

Not reproducible on

Brave 1.17.75 Chromium: 87.0.4280.88 (Official Build) (64-bit)
Revision 89e2380a3e36c3464b5dd1302349b1382549290d-refs/branch-heads/4280@{#1761}
OS Linux

Version/Channel Information:

  • Can you reproduce this issue with the current release? yes
  • Can you reproduce this issue with the beta channel? yes
  • Can you reproduce this issue with the nightly channel? yes

cc @brave/legacy_qa @rebron @emerick @zenparsing

@emerick
Copy link
Contributor

emerick commented Jan 20, 2021

It seems like the label text isn't reflowing and instead obscures the toggle button in certain languages.

@zenparsing
Copy link

@emerick Good call - should be a small CSS fix.

@stephendonner
Copy link

stephendonner commented Feb 9, 2021

Verified FIXED using the steps to reproduce from this Issue, on

Brave 1.21.47 Chromium: 88.0.4324.152 (Oficjalna wersja) beta (x86_64)
Wersja 6579930fc53b4dc589c042bec9d0a3778326974d-refs/branch-heads/4324@{#2106}
System operacyjny macOS Wersja 11.2 (kompilacja 20D64)

Zrzut ekranu 2021-02-8 o 4 32 59 PM


Verification passed on

Brave 1.21.52 Chromium: 88.0.4324.152 (Official Build) dev (64-bit)
Revision 6579930fc53b4dc589c042bec9d0a3778326974d-refs/branch-heads/4324@{#2106}
OS Ubuntu 18.04 LTS

Verified test plan from the description

image
image


Verification passed on

Brave | 1.21.56 Chromium: 88.0.4324.152 (Oficjalna wersja) dev (64-bitowa)
-- | --
Wersja | 6579930fc53b4dc589c042bec9d0a3778326974d-refs/branch-heads/4324@{#2106}
System operacyjny | Windows 10 OS Version 2004 (Build 19041.804)

Verified test plan from the description
image
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment