Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

brave://discards table header is unreadable on dark theme #13600

Open
LaurenWags opened this issue Jan 15, 2021 · 1 comment
Open

brave://discards table header is unreadable on dark theme #13600

LaurenWags opened this issue Jan 15, 2021 · 1 comment
Labels
about-pages/misc feature/themes OS/Desktop priority/P5 Not scheduled. Don't anticipate work on this any time soon. QA/Yes

Comments

@LaurenWags
Copy link
Member

Description

Found while testing #10451

The table header on brave://discards page is unreadable on dark theme. Looks fine on light theme.

Does not reproduce on Chrome.

Steps to Reproduce

  1. Have dark theme set
  2. Navigate to brave://discards
  3. Table header is unreadable (white text on light blue background)
  4. Switch to light theme
  5. Table header is readable

Actual result:

Dark Light
Brave-dark Brave-light

Expected result:

Chrome's dark themed page for comparison
Chrome-dark

Reproduces how often:

easily

Brave version (brave://version info)

Brave 1.19.84 Chromium: 88.0.4324.87 (Official Build) (x86_64)
Revision dd01ff8f58c65af81127ad5c105c79d5b571d8f3-refs/branch-heads/4324@{#1702}
OS macOS Version 10.15.7 (Build 19H15)

Version/Channel Information:

  • Can you reproduce this issue with the current release? 1.18.x is n/a (broken), 1.19.x yes
  • Can you reproduce this issue with the beta channel? 1.20.x yes
  • Can you reproduce this issue with the nightly channel? 1.21.x yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? n/a
  • Does the issue resolve itself when disabling Brave Rewards? n/a
  • Is the issue reproducible on the latest version of Chrome? no

Miscellaneous Information:

cc @rebron @brave/legacy_qa

@wyatt400
Copy link

wyatt400 commented Jul 1, 2021

@rebron Seems fixed, test this again, should close this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
about-pages/misc feature/themes OS/Desktop priority/P5 Not scheduled. Don't anticipate work on this any time soon. QA/Yes
Projects
Status: P5 backlog
Development

No branches or pull requests

3 participants