Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verifiable Advertiser Conversions #13368

Closed
moritzhaller opened this issue Jan 5, 2021 · 1 comment · Fixed by brave/brave-core#7524
Closed

Verifiable Advertiser Conversions #13368

moritzhaller opened this issue Jan 5, 2021 · 1 comment · Fixed by brave/brave-core#7524
Assignees
Labels
enhancement feature/ads OS/Android Fixes related to Android browser functionality OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA/Yes release-notes/include

Comments

@moritzhaller
Copy link

No description provided.

@btlechowski
Copy link

btlechowski commented Apr 8, 2021

Verification passed on

Brave 1.23.63 Chromium: 89.0.4389.114 (Official Build) beta (64-bit)
Revision 1ea76e193b4fadb723bfea2a19a66c93a1bc0ca6-refs/branch-heads/4389@{#1616}
OS Ubuntu 18.04 LTS

Verified Notification ad - verifiable conversions from https://github.com/brave/internal/issues/758

Verified conversion was triggered

[19349:19349:0408/152448.838880:VERBOSE1:conversions.cc(146)] Checking URL for conversions
[19349:19349:0408/152448.847492:VERBOSE1:conversions.cc(250)] Conversion for campaign id ccdaf616-b8a8-481a-aa8b-caf5fb131353, creative set id 57388e7d-e0fd-4f30-a76a-3d7fb2e6d8a1, creative instance id 6f5decfc-57cb-4a42-8523-e372c7d4adff and advertiser id  in 0 hours, 0 minutes, 0 seconds at 3:24 PM
[19349:19349:0408/152448.865647:VERBOSE6:conversions.cc(303)] Successfully logged conversion event
[19349:19349:0408/152448.874718:VERBOSE3:conversions.cc(326)] Successfully appended conversion to queue
[19349:19349:0408/152448.885560:VERBOSE1:conversions.cc(430)] Convert campaign id ccdaf616-b8a8-481a-aa8b-caf5fb131353, creative set id 57388e7d-e0fd-4f30-a76a-3d7fb2e6d8a1, creative instance id 6f5decfc-57cb-4a42-8523-e372c7d4adff and advertiser id  in 0 hours, 3 minutes, 18 seconds at 3:28 PM

Verified conversion was successful

[19349:19349:0408/152806.852037:VERBOSE1:conversions.cc(371)] Successfully converted ad with campaign id ccdaf616-b8a8-481a-aa8b-caf5fb131353, creative set id 57388e7d-e0fd-4f30-a76a-3d7fb2e6d8a1, creative instance id 6f5decfc-57cb-4a42-8523-e372c7d4adff and advertiser id  on Thursday, April 8, 2021 at 3:28:06 PM
[19349:19349:0408/152806.852119:VERBOSE1:confirmations.cc(89)] Confirming conversion ad for creative instance id 6f5decfc-57cb-4a42-8523-e372c7d4adff
Could not read 32 byes from /dev/urandom. Abort.
[19349:19349:0408/152806.856289:VERBOSE1:redeem_unblinded_token.cc(50)] Redeem unblinded token
[19349:19349:0408/152806.856591:VERBOSE1:redeem_unblinded_token.cc(64)] CreateConfirmation
[19349:19349:0408/152806.856917:VERBOSE2:redeem_unblinded_token.cc(65)] POST /v1/confirmation/{confirmation_id}/{credential}
[19349:19349:0408/152806.857097:VERBOSE5:redeem_unblinded_token.cc(69)] URL Request:
  URL: https://ads-serve.bravesoftware.com/v1/confirmation/fe6dbecf-67f2-49ef-8c84-c36ac70ffe43/eyJwYXlsb2FkIjoie1wiYmxpbmRlZFBheW1lbnRUb2tlblwiOlwib3J1bG5PdVRkS1RIWnJkVkdWbFVNWDZQYWFSNkptSUNib3lWR0VDYzRCaz1cIixcImJ1aWxkQ2hhbm5lbFwiOlwiYmV0YVwiLFwiY29udmVyc2lvbkVudmVsb3BlXCI6e1wiYWxnXCI6XCJjcnlwdG9fYm94X2N1cnZlMjU1MTl4c2Fsc2EyMHBvbHkxMzA1XCIsXCJjaXBoZXJ0ZXh0XCI6XCJtMzdpMGw3SFVQbUxiMWRsU0N5YjR4RXpaeE44Zy9WU1Q0eHFnL1JlbklSeHloRHc0TU1EcjJzUU1wWThPQm93XCIsXCJlcGtcIjpcIkwrVjlvMGZOWWtNVktOcXNYN3NwQnpELzlvU3Z4TS9DN1pDWlgxakxPM1E9XCIsXCJub25jZVwiOlwiKzl3WE9GbHpNL2ZuUG1LQzMyRncraTJlUGFZSUFwc25cIn0sXCJjcmVhdGl2ZUluc3RhbmNlSWRcIjpcIjZmNWRlY2ZjLTU3Y2ItNGE0Mi04NTIzLWUzNzJjN2Q0YWRmZlwiLFwiZXhwZXJpbWVudFwiOnt9LFwicGF5bG9hZFwiOnt9LFwicGxhdGZvcm1cIjpcImxpbnV4XCIsXCJ0eXBlXCI6XCJjb252ZXJzaW9uXCJ9Iiwic2lnbmF0dXJlIjoiTnMxaW5sOWdQVjdla3ZGYklvaXo2R3F3K2UxWHppYW5zTWFKLzJVRjQzek45b3IzNWpDbjVIU2hYb1I1YktNeG41S1VKbHlrSXU0aWZ2bmxMbUg1dHc9PSIsInQiOiJKM2JaRWpKWVRtY3RYM2FXZUxpREFGc2RqUGpvVmZ5VTBlYUo1N3VhZmdGYTRCWTdwR1pkKzhORGhsR1RINS9kZ0RpNi9OMDVwSjhoc0RWM1Y2cVNpUT09In0=
  Content: {"blindedPaymentToken":"orulnOuTdKTHZrdVGVlUMX6PaaR6JmICboyVGECc4Bk=","buildChannel":"beta","conversionEnvelope":{"alg":"crypto_box_curve25519xsalsa20poly1305","ciphertext":"m37i0l7HUPmLb1dlSCyb4xEzZxN8g/VST4xqg/RenIRxyhDw4MMDr2sQMpY8OBow","epk":"L+V9o0fNYkMVKNqsX7spBzD/9oSvxM/C7ZCZX1jLO3Q=","nonce":"+9wXOFlzM/fnPmKC32Fw+i2ePaYIApsn"},"creativeInstanceId":"6f5decfc-57cb-4a42-8523-e372c7d4adff","experiment":{},"payload":{},"platform":"linux","type":"conversion"}
  Content Type: application/json
  Method: BraveAdsUrlRequestMethod::POST
[19349:19349:0408/152806.869713:VERBOSE3:conversions.cc(341)] Successfully removed conversion from queue
[19349:19349:0408/152806.870888:VERBOSE1:conversions.cc(125)] Conversion queue is empty
[19349:19349:0408/152807.789251:VERBOSE1:redeem_unblinded_token.cc(82)] OnCreateConfirmation
[19349:19349:0408/152807.789330:VERBOSE6:redeem_unblinded_token.cc(84)] URL Response:
  URL: https://ads-serve.bravesoftware.com/v1/confirmation/fe6dbecf-67f2-49ef-8c84-c36ac70ffe43/eyJwYXlsb2FkIjoie1wiYmxpbmRlZFBheW1lbnRUb2tlblwiOlwib3J1bG5PdVRkS1RIWnJkVkdWbFVNWDZQYWFSNkptSUNib3lWR0VDYzRCaz1cIixcImJ1aWxkQ2hhbm5lbFwiOlwiYmV0YVwiLFwiY29udmVyc2lvbkVudmVsb3BlXCI6e1wiYWxnXCI6XCJjcnlwdG9fYm94X2N1cnZlMjU1MTl4c2Fsc2EyMHBvbHkxMzA1XCIsXCJjaXBoZXJ0ZXh0XCI6XCJtMzdpMGw3SFVQbUxiMWRsU0N5YjR4RXpaeE44Zy9WU1Q0eHFnL1JlbklSeHloRHc0TU1EcjJzUU1wWThPQm93XCIsXCJlcGtcIjpcIkwrVjlvMGZOWWtNVktOcXNYN3NwQnpELzlvU3Z4TS9DN1pDWlgxakxPM1E9XCIsXCJub25jZVwiOlwiKzl3WE9GbHpNL2ZuUG1LQzMyRncraTJlUGFZSUFwc25cIn0sXCJjcmVhdGl2ZUluc3RhbmNlSWRcIjpcIjZmNWRlY2ZjLTU3Y2ItNGE0Mi04NTIzLWUzNzJjN2Q0YWRmZlwiLFwiZXhwZXJpbWVudFwiOnt9LFwicGF5bG9hZFwiOnt9LFwicGxhdGZvcm1cIjpcImxpbnV4XCIsXCJ0eXBlXCI6XCJjb252ZXJzaW9uXCJ9Iiwic2lnbmF0dXJlIjoiTnMxaW5sOWdQVjdla3ZGYklvaXo2R3F3K2UxWHppYW5zTWFKLzJVRjQzek45b3IzNWpDbjVIU2hYb1I1YktNeG41S1VKbHlrSXU0aWZ2bmxMbUg1dHc9PSIsInQiOiJKM2JaRWpKWVRtY3RYM2FXZUxpREFGc2RqUGpvVmZ5VTBlYUo1N3VhZmdGYTRCWTdwR1pkKzhORGhsR1RINS9kZ0RpNi9OMDVwSjhoc0RWM1Y2cVNpUT09In0=
  Response Status Code: 201
  Response: {"id":"fe6dbecf-67f2-49ef-8c84-c36ac70ffe43","payload":{},"createdAt":"2021-04-08T13:28:07.618Z","type":"conversion","modifiedAt":"2021-04-08T13:28:07.618Z","creativeInstanceId":"6f5decfc-57cb-4a42-8523-e372c7d4adff"}
[19349:19349:0408/152807.789441:VERBOSE1:redeem_unblinded_token.cc(104)] FetchPaymentToken
[19349:19349:0408/152807.789500:VERBOSE2:redeem_unblinded_token.cc(105)] GET /v1/confirmation/{confirmation_id}/paymentToken
[19349:19349:0408/152807.789543:VERBOSE5:redeem_unblinded_token.cc(109)] URL Request:
  URL: https://ads-serve.bravesoftware.com/v1/confirmation/fe6dbecf-67f2-49ef-8c84-c36ac70ffe43/paymentToken
  Method: BraveAdsUrlRequestMethod::GET
[19349:19349:0408/152808.044627:VERBOSE1:redeem_unblinded_token.cc(120)] OnFetchPaymentToken
[19349:19349:0408/152808.044721:VERBOSE6:redeem_unblinded_token.cc(122)] URL Response:
  URL: https://ads-serve.bravesoftware.com/v1/confirmation/fe6dbecf-67f2-49ef-8c84-c36ac70ffe43/paymentToken
  Response Status Code: 200
  Response: {"id":"fe6dbecf-67f2-49ef-8c84-c36ac70ffe43","createdAt":"2021-04-08T13:28:07.618Z","type":"conversion","modifiedAt":"2021-04-08T13:28:07.636Z","creativeInstanceId":"6f5decfc-57cb-4a42-8523-e372c7d4adff","paymentToken":{"publicKey":"lLO5tErGoTK0askrALab6pKGAnBHqELSyw/evqZRwH8=","batchProof":"TREWTlqkVlecUTzD0yWcCHte8OzlpDpYi9wJjIafIggnaKQDo6RcRRQD4ABOxfiwVWoQyBP3EQeErFDcSUlnDw==","signedTokens":["XJLqb/ZIxK4T7Rv+vWQslGy4EcOvBykwQkE+VF839BQ="]}}
[19349:19349:0408/152808.044815:VERBOSE1:confirmations.cc(248)] Successfully redeemed unblinded token with confirmation id fe6dbecf-67f2-49ef-8c84-c36ac70ffe43, creative instance id 6f5decfc-57cb-4a42-8523-e372c7d4adff and conversion

Verified confirmation request contains ConversionEnvelope
image

Verified Notification ad - verifiable conversions - localhost from https://github.com/brave/internal/issues/758 and brave/brave-core#7524
Verified able to create my own key-pair:
image

Verified page contains <meta name="ad-conversion-id" content="qatest123">
image
Verified conversion was successful:

[21627:21627:0408/172416.502358:VERBOSE1:conversions.cc(371)] Successfully converted ad with campaign id ccdaf616-b8a8-481a-aa8b-caf5fb131353, creative set id 57388e7d-e0fd-4f30-a76a-3d7fb2e6d8a1, creative instance id 6f5decfc-57cb-4a42-8523-e372c7d4adff and advertiser id  on Thursday, April 8, 2021 at 5:01:48 PM

Verified confirmation request contains ConversionEnvelope

{
	"blindedPaymentToken": "ZH/JOb7/FnFOsiYkf1CprRKIA/zRlpTPSxnb9ok5lDU=",
	"buildChannel": "beta",
	"conversionEnvelope": {
		"alg": "crypto_box_curve25519xsalsa20poly1305",
		"ciphertext": "vMvLtjbOBcYejJ48KdMKxQmTjSYPClDjrVKFkOReHmLMkIt+9Y+7B/9M50OtXNFn",
		"epk": "L+V9o0fNYkMVKNqsX7spBzD/9oSvxM/C7ZCZX1jLO3Q=",
		"nonce": "Ir87i6CazECqJ55N8po6MZrMzLhqDlou"
	},
	"creativeInstanceId": "6f5decfc-57cb-4a42-8523-e372c7d4adff",
	"experiment": {},
	"payload": {},
	"platform": "linux",
	"type": "conversion"
}

Verified able to decipher the message:
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement feature/ads OS/Android Fixes related to Android browser functionality OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA/Yes release-notes/include
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants