Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewards popup doesn't show translated strings #13199

Closed
cniweb opened this issue Dec 15, 2020 · 4 comments · Fixed by brave/brave-core#7486
Closed

Rewards popup doesn't show translated strings #13199

cniweb opened this issue Dec 15, 2020 · 4 comments · Fixed by brave/brave-core#7486

Comments

@cniweb
Copy link

cniweb commented Dec 15, 2020

Description

Rewards extension popup doesn't display translated strings.

Steps to Reproduce

  1. Open rewards popup

Actual result:

Below is the result with german locale:
Bildschirmfoto 2020-12-15 um 08 52 25

Expected result:

German strings

Reproduces how often:

Easily reproduced

Brave version (brave://version info)

Brave | 1.18.70 Chromium: 87.0.4280.101 (Offizieller Build) (x86_64)
Überarbeitung | 9407c80213cda69c2b7abcb4fa8e3f74488f4956-refs/branch-heads/4280@{#1807}
Betriebssystem | macOS Version 11.0.1 (Build 20B50)
User-Agent | Mozilla/5.0 (Macintosh; Intel Mac OS X 11_0_1) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/87.0.4280.101 Safari/537.36
Pfad zur ausführbaren Datei | /Applications/Brave Browser.app/Contents/MacOS/Brave Browser

@mkarolin
Copy link
Contributor

Thank you for filing the issue @cniweb. If you have a moment to check, is there a folder with your locale under /Applications/Brave\ Browser.app/Contents/Frameworks/Brave\ Browser\ Framework.framework/Versions/87.1.18.70/Resources/brave_rewards/_locales/, and if so, does it contain a messages.json file?

@Brave-Matt
Copy link

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Dec 28, 2020

Verification passed on


Brave | 1.18.77 Chromium: 87.0.4280.101 (Offizieller Build) (64-Bit)
-- | --
Überarbeitung | 9407c80213cda69c2b7abcb4fa8e3f74488f4956-refs/branch-heads/4280@{#1807}
Betriebssystem | Windows 10 OS Version 2004 (Build 19041.685)

  • Verified the STR from the description

German locale
Settings page:
image
image

BR panel:
image
image

Kannada locale:
image
image

France locale:
image
image
image
image

Verification PASSED on macOS 11.1 using the following build:

Brave | 1.18.77 Chromium: 87.0.4280.101 (Official Build) (x86_64)
-- | --
Revision | 9407c80213cda69c2b7abcb4fa8e3f74488f4956-refs/branch-heads/4280@{#1807}
OS | macOS Version 11.1 (Build 20C69)
Example Example
Bildschirmfoto 2020-12-29 um 12 05 37 AM Bildschirmfoto 2020-12-29 um 12 05 56 AM

Verification PASSED on Mint 19.1 using the following build:

Brave | 1.18.77 Chromium: 87.0.4280.101 (Official Build) (64-bit)
--- | ---
Revision | 9407c80213cda69c2b7abcb4fa8e3f74488f4956-refs/branch-heads/4280@{#1807}
OS | Linux
Example Example
image image

@cniweb
Copy link
Author

cniweb commented Dec 28, 2020

Thanks 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment