Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NTP is causing higher CPU / GPU usage #13194

Closed
petemill opened this issue Dec 14, 2020 · 3 comments · Fixed by brave/brave-core#7433
Closed

NTP is causing higher CPU / GPU usage #13194

petemill opened this issue Dec 14, 2020 · 3 comments · Fixed by brave/brave-core#7433

Comments

@petemill
Copy link
Member

Description

Multiple reports from users that the New Tab Page is causing persistently higher CPU usage either in

  • The Tab's process
  • The Browser's GPU process
  • (macOS) WindowServer process

This seems to be as a result of introducing Brave Today and more specifically the "hint" arrow pointing down to scroll, since turning the feature off immediately removes the extra CPU usage.

Steps to Reproduce

on macOS

  1. Open NTP
  2. Enable Brave Today if not enabled
  3. Open Brave's Task Manager

Actual result:

High CPU (relative to normal, percentage is different for everyone, depending on hardware)

Expected result:

Same CPU usage as without Brave Today enabled.

Reproduces how often:

100%

Brave version (brave://version info)

1.18.70

Version/Channel Information:

  • Can you reproduce this issue with the current release? Yes
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

@FutureLearnSole
Copy link

Ungrateful Brave End User 2020 here, just saying that if not for that scroll down arrow, NF given. Ciao.

Paying last respects to its jiggly,

@FutureLearnSole
Copy link

#13196 (comment)

@rebron rebron added the priority/P2 A bad problem. We might uplift this to the next planned release. label Dec 15, 2020
@petemill petemill added this to the 1.20.x - Nightly milestone Dec 15, 2020
@LaurenWags
Copy link
Member

LaurenWags commented Dec 17, 2020

Verified passed on macOS using

Brave | 1.18.74 Chromium: 87.0.4280.101 (Official Build) (x86_64)
-- | --
Revision | 9407c80213cda69c2b7abcb4fa8e3f74488f4956-refs/branch-heads/4280@{#1807}
OS | macOS Version 10.15.7 (Build 19H15)
  • ensured that the "arrow down" animation was removed from NTP
  • ensured that scrolling through Brave Today works without any issues
  • ensured that there's an improvement in performance once the animation was removed
With Animation using 1.18.70 Without Animation using 1.18.74
1 18 70 BT enabled 1 18 74 BT enabled

Verification passed on

Brave 1.18.74 Chromium: 87.0.4280.101 (Official Build) (64-bit)
Revision 9407c80213cda69c2b7abcb4fa8e3f74488f4956-refs/branch-heads/4280@{#1807}
OS Ubuntu 18.04 LTS
  • ensured that the "arrow down" animation was removed from NTP
  • ensured that scrolling through Brave Today works without any issues
  • ensured that there's an improvement in performance once the animation was removed
With Animation using 1.18.70 Without Animation using 1.18.74
image image

Verification passed on

Brave 1.18.75 Chromium: 87.0.4280.101 (Official Build) (64-bit)
Revision 9407c80213cda69c2b7abcb4fa8e3f74488f4956-refs/branch-heads/4280@{#1807}
OS Windows 7 Service Pack 1 (Build 7601.24544)
  • ensured that the "arrow down" animation was removed from NTP
  • ensured that scrolling through Brave Today works without any issues
  • ensured that there's an improvement in performance once the animation was removed
With Animation using 1.18.70 Without Animation using 1.18.75
image image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants