Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

decrease font-weight to medium=500 for focused tab follow up to #8576 #13174

Closed
rebron opened this issue Dec 11, 2020 · 2 comments · Fixed by brave/brave-core#7416
Closed

decrease font-weight to medium=500 for focused tab follow up to #8576 #13174

rebron opened this issue Dec 11, 2020 · 2 comments · Fixed by brave/brave-core#7416
Assignees
Labels
design A design change, especially one which needs input from the design team OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/exclude

Comments

@rebron
Copy link
Collaborator

rebron commented Dec 11, 2020

Description

#8576 sought to improve tab contrast. The font-weight for the focused tab is semi-bold = 600 but should be reduced to medium = 500.

Steps to Reproduce

  1. Open browser and open a few tabs.
  2. Notice weighting on focused tab is semi-bold

Actual result:

Screen Shot 2020-12-11 at 2 24 42 PM

Expected result:

Slightly less bold

Reproduces how often:

Easily.

Brave version (brave://version info)

Version/Channel Information:

  • Can you reproduce this issue with the current release? yes
  • Can you reproduce this issue with the beta channel? yes
  • Can you reproduce this issue with the nightly channel? yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? n/a
  • Does the issue resolve itself when disabling Brave Rewards? n/a
  • Is the issue reproducible on the latest version of Chrome? n/a

Miscellaneous Information:

cc: @karenkliu

@rebron rebron added priority/P3 The next thing for us to work on. It'll ride the trains. design A design change, especially one which needs input from the design team labels Dec 11, 2020
simonhong added a commit to brave/brave-core that referenced this issue Dec 12, 2020
bsclifton pushed a commit to brave/brave-core that referenced this issue Dec 14, 2020
simonhong added a commit to brave/brave-core that referenced this issue Dec 15, 2020
@bsclifton bsclifton added this to the 1.20.x - Nightly milestone Dec 15, 2020
@kjozwiak kjozwiak added QA/Yes and removed QA/No labels Jan 6, 2021
@GeetaSarvadnya
Copy link

To test this we would need a new build that is greater than 1.19.76

@btlechowski
Copy link

btlechowski commented Jan 8, 2021

Verification passed on

Brave 1.19.78 Chromium: 87.0.4280.101 (Official Build) dev (64-bit)
Revision 9407c80213cda69c2b7abcb4fa8e3f74488f4956-refs/branch-heads/4280@{#1807}
OS Ubuntu 18.04 LTS

Verified that the font is less bold in 1.19.x
Dark mode
1.18.x
image
1.19.x
image

Light mode
1.18.x
image
1.19.x
image


Verified passed with

Brave | 1.19.79 Chromium: 87.0.4280.141 (Official Build) dev (x86_64)
-- | --
Revision | 9f05d1d9ee7483a73e9fe91ddcb8274ebcec9d7f-refs/branch-heads/4280@{#2007}
OS | macOS Version 10.15.7 (Build 19H15)

Verified STR from description.
Confirmed Release 1.18.x tab title is slightly bolder than Dev 1.19.x tab title.

Light Screen Shot 2021-01-11 at 2 42 52 PM Screen Shot 2021-01-11 at 2 43 04 PM
Dark Screen Shot 2021-01-11 at 2 41 42 PM Screen Shot 2021-01-11 at 2 41 54 PM

Verification passed on


Brave | 1.19.82 Chromium: 88.0.4324.79 (Official Build) dev (64-bit)
-- | --
Revision | bd1e9353659b2491dac971226a973ca3b5684a14-refs/branch-heads/4324@{#1520}
OS | Windows 10 OS Version 2004 (Build 19041.685)

Verified STR from the description.
Confirmed Release 1.18.x tab title is slightly bolder than Dev 1.19.x tab title.

Light theme

image
image

Dark theme

image
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design A design change, especially one which needs input from the design team OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/exclude
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants