Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reset settings is not translated under brave://settings/reset #13121

Closed
btlechowski opened this issue Dec 9, 2020 · 2 comments · Fixed by brave/brave-core#7417
Closed

Reset settings is not translated under brave://settings/reset #13121

btlechowski opened this issue Dec 9, 2020 · 2 comments · Fixed by brave/brave-core#7417

Comments

@btlechowski
Copy link

Follow up to: #13040

Steps to Reproduce

  1. Open brave://settings/reset
  2. Check if Reset settings is translated

Actual result:

Reset settings is not translated
image

Expected result:

Reset settings is translated

Reproduces how often:

Easily reproduced

Brave version (brave://version info)

Brave 1.18.70 Chromium: 87.0.4280.101 (Official Build) (64-bit)
Revision 9407c80213cda69c2b7abcb4fa8e3f74488f4956-refs/branch-heads/4280@{#1807}
OS Windows 7 Service Pack 1 (Build 7601.24544)
Brave 1.20.17 Chromium: 87.0.4280.88 (Official Build) nightly (64-bit)
Revision 89e2380a3e36c3464b5dd1302349b1382549290d-refs/branch-heads/4280@{#1761}
OS Windows 7 Service Pack 1 (Build 7601.24544)

cc @brave/legacy_qa @mkarolin @rebron

@btlechowski
Copy link
Author

This is a regression.

Not reproducible on

Brave 1.17.75 Chromium: 87.0.4280.88 (Official Build) (64-bit)
Revision 89e2380a3e36c3464b5dd1302349b1382549290d-refs/branch-heads/4280@{#1761}
OS Windows 7 Service Pack 1 (Build 7601.24544)

image

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Jan 7, 2021

Verification passed on


rave | 1.19.76 Chromium: 87.0.4280.101 (ಅಧಿಕೃತವಾಗಿ ನಿರ್ಮಿಸಿ) dev (64-ಬಿಟ್)
-- | --
ಪರಿಷ್ಕರಣೆ | 9407c80213cda69c2b7abcb4fa8e3f74488f4956-refs/branch-heads/4280@{#1807}
OS | Windows 10 OS Version 2004 (Build 19041.685)

  • Verified few locales and ensured that Reset Settings is translated

Kannada
image

Hindi
image

Dutch _(Netherland)_
image


Verified passed with

Brave | 1.19.78 Chromium: 87.0.4280.101 (Official Build) dev (x86_64)
-- | --
Revision | 9407c80213cda69c2b7abcb4fa8e3f74488f4956-refs/branch-heads/4280@{#1807}
OS | macOS Version 10.15.7 (Build 19H15)
German German
French French
Polish Polish

Verification passed on

Brave 1.19.78 Chromium: 87.0.4280.101 (Official Build) dev (64-bit)
Revision 9407c80213cda69c2b7abcb4fa8e3f74488f4956-refs/branch-heads/4280@{#1807}
OS Ubuntu 18.04 LTS

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants