Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dark Mode on Windows 10 different color black #13102

Open
underling3311 opened this issue Dec 9, 2020 · 14 comments
Open

Dark Mode on Windows 10 different color black #13102

underling3311 opened this issue Dec 9, 2020 · 14 comments
Assignees
Labels
design A design change, especially one which needs input from the design team feature/themes OS/Desktop priority/P4 Planned work. We expect to get to it "soon".

Comments

@underling3311
Copy link

underling3311 commented Dec 9, 2020

Description

There is a different type of black in dark mode inside of windows 10.
I like the Black before the update change.

Actual result:

Brave Different Black

Version/Channel Information:

  • Can you reproduce this issue with the current release? NO
  • Can you reproduce this issue with the beta channel? Yes
    • Can you reproduce this issue with the DEV channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes

Note:
Make sure you have dark mode turned on for both windows and brave browser

@rebron rebron added the design A design change, especially one which needs input from the design team label Jan 15, 2021
@rebron
Copy link
Collaborator

rebron commented Jan 15, 2021

cc: @karenkliu @bradleyrichter
Let's keep an eye on the feedback, I'm not sure we got enough from beta and nightly users.

@rebron rebron self-assigned this Jan 15, 2021
@underling3311
Copy link
Author

underling3311 commented Jan 15, 2021

@rebron

Another Problem and don't want to make a report...

  1. On the sheild turn on aggressive for the block list.
  2. Go to pornhub.com
  3. Videos don't load.

Don't ask..

@antonok-edm
Copy link
Collaborator

@MrWaste I'm unable to reproduce that on my end, on both Release and Nightly...
cc @ryanbr just in case

@underling3311
Copy link
Author

@antonok-edm

Proof:
I use Tor with the Beta Brave.

2021-01-15_112810

@underling3311
Copy link
Author

underling3311 commented Jan 15, 2021

Of right now for the main issue still here. I am not sure which you are referring to @antonok-edm
The hub or dark mode

2021-01-15_113203

Note:
Make sure you have dark mode turned on for both windows and brave browser

@ryanbr
Copy link

ryanbr commented Jan 15, 2021

I just tested various pornhub videos, no issues with playback. Whitespace issues can be removed via Aggressive mode, but default shields is working. @MrWaste

pornhub

@underling3311
Copy link
Author

underling3311 commented Jan 16, 2021

@ryanbr Did you try on the Beta, Dev, or Nightly?
Not the main, it works there.

hm

@DevBefell
Copy link

I also, like the old dark mode than the new one, for the new one the search results background is too dark and could be a lighter color:
image
My Brave version is:
image

@underling3311
Copy link
Author

@PyICoder Thank you for this picture of proof!

@LUC18fknU7P
Copy link

image
Looks really blue than a neutral dark, Is there any workaround to turn on the old colors?

@LUC18fknU7P
Copy link

LUC18fknU7P commented Jan 25, 2021

[image]
Looks really blue than a neutral dark, Is there any workaround to turn on the old colors?

Found a work around from: https://www.reddit.com/r/brave_browser/comments/l1876f/design_change_earlier_the_titlebar_and_tabs_were/gjxtxij?utm_source=share&utm_medium=web2x&context=3

  • Go to brave://flags
  • Search for #enable-new-profile-picker and enable
  • Go to Settings and go to Profile name and icon
  • Pick a theme color and click the first option (custom color)
  • Put in hex code #161616

@wsor4035
Copy link

I also prefer the old dark mode color scheme

@wsor4035
Copy link

[image]
Looks really blue than a neutral dark, Is there any workaround to turn on the old colors?

Found a work around from: https://www.reddit.com/r/brave_browser/comments/l1876f/design_change_earlier_the_titlebar_and_tabs_were/gjxtxij?utm_source=share&utm_medium=web2x&context=3

  • Go to brave://flags
  • Search for #enable-new-profile-picker and enable
  • Go to Settings and go to Profile name and icon
  • Pick a theme color and click the first option (custom color)
  • Put in hex code #161616

Unfortunately for me when this is enabled, clicking on the profile icon causes the browser to crash. completely understand as its a in development feature.

@LUC18fknU7P
Copy link

[image]
Looks really blue than a neutral dark, Is there any workaround to turn on the old colors?

Found a work around from: https://www.reddit.com/r/brave_browser/comments/l1876f/design_change_earlier_the_titlebar_and_tabs_were/gjxtxij?utm_source=share&utm_medium=web2x&context=3

  • Go to brave://flags
  • Search for #enable-new-profile-picker and enable
  • Go to Settings and go to Profile name and icon
  • Pick a theme color and click the first option (custom color)
  • Put in hex code #161616

Unfortunately for me when this is enabled, clicking on the profile icon causes the browser to crash. completely understand as its a in development feature.

Issue #13822 tracking that bug. Looks like this is the culprit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design A design change, especially one which needs input from the design team feature/themes OS/Desktop priority/P4 Planned work. We expect to get to it "soon".
Projects
Status: P4 backlog
Status: Needs Info
Development

No branches or pull requests

7 participants