Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't hide Bookmarks bar on New Tab page #1306

Closed
Brave-Matt opened this issue Sep 26, 2018 · 43 comments · Fixed by brave/brave-core#2563
Closed

Can't hide Bookmarks bar on New Tab page #1306

Brave-Matt opened this issue Sep 26, 2018 · 43 comments · Fixed by brave/brave-core#2563

Comments

@Brave-Matt
Copy link

Description

Even with the "Show Bookmarks Bar" option set to off, Brave still displays bookmarks bar on the new tab screen. There should be an option to turn this off. Tangentially related to #1022
Note: Chrome behaves in this same way (at the time of writing this, Chrome v69.0.3497.100) so this is more of a feature request than a bug. Would be good to have an option for this before Chrome.

Steps to Reproduce

  1. Add some bookmarks to the bookmarks bar
  2. Go to Settings --> Appearance --> Show Bookmarks Bar and toggle option to off
  3. Visit some website, then open a new tab

Actual result:

Bookmarks Bar is not shown when viewing website tab as expected but new tab page still shows bookmarks bar.

Expected result:

Bookmarks bar should not be visible anywhere until option is turned back on.

Reproduces how often:

Always.

Brave version (chrome://version info)

Version 0.55.6 Chromium: 70.0.3538.16 (Official Build) dev (64-bit)

Website problems only:

  • Is the issue reproducible on the latest version of Chrome? Yes

Additional Information

Screenshots:
image

image

@Brave-Matt
Copy link
Author

@bsclifton bsclifton added this to the 2.x Backlog milestone Sep 26, 2018
@rebron rebron modified the milestones: 2.x Backlog, 1.x Backlog, 1.0 (0.56.x) Sep 26, 2018
@rebron rebron changed the title Option to not always show Bookmarks Bar in new tab Can't hide Bookmarks bar on New Tab page Sep 26, 2018
@rebron rebron added the bug label Sep 26, 2018
@Brave-Matt
Copy link
Author

@rebron, not that I mind but to clarify, is there a particular reason you retitled and labeled it as bug? I'm just wondering because Chrome behaves this way as well on live release (also doesn't have option to change it).

@bbondy bbondy modified the milestones: 1.0 (0.56.x), 1.x Backlog Sep 29, 2018
@rebron rebron added the priority/P3 The next thing for us to work on. It'll ride the trains. label Oct 5, 2018
@Jacalz
Copy link
Contributor

Jacalz commented Oct 20, 2018

I really want to see this fixed too, the bookmarks bar looks visually not pleasing and it makes the new tab page look less beautiful than what it really is...

@srirambv
Copy link
Contributor

+1 from @NumpDeP via #1919 for private window

@StephD
Copy link

StephD commented Nov 9, 2018

+1 also on Brave. No problem on chrome 70

@simonhong
Copy link
Member

Do we want to make bookmark in ntp also follow bookmark visibility prefs? @rebron

@nicolinux
Copy link

If you don't have (and want) any bookmarks, you still see this annoying bar.
Version 0.56.12 Chromium: 70.0.3538.77 (Official Build) (64-bit)

screen shot 2018-11-11 at 18 19 57

@srirambv
Copy link
Contributor

srirambv commented Dec 3, 2018

+1 from #1306

@Ilya-MV
Copy link

Ilya-MV commented Dec 6, 2018

I updated the browser, but the essence of the issue has not changed! It would be much more convenient if the bookmarks were located on the menu bar, not on the bookmarks bar! This allows you to remove the bookmarks bar and thereby increase the height of the main working browser window! Where h < H = absolute benefit![
img-2018-12-05-18-32-14

@kjozwiak
Copy link
Member

kjozwiak commented Jan 3, 2019

Added into the General project so this issue gets triaged as there's a few +1 from the community.

Also +1 from me as well. When using the white theme, you'll just see an empty blank bar at the top even though the Bookmarks Bar isn't enabled:

screen shot 2019-01-03 at 11 05 26 am

@jatinw21
Copy link

I would love to see this fixed too. It makes the otherwise beautiful page look ugly and is annoying.

@eljuno
Copy link

eljuno commented Jan 30, 2019

@JoshuaCarter
Copy link

Just finished migrating from Ubuntu's 'Software' version of Brave to the new src repo, and just noticed that the bookmarks bar is gone on new tabs, meaning I have to have it on all the time (waste of visual space and ugly). Any way to get it showing on just new tabs again?

@simonhong
Copy link
Member

I think some users will want to show bookmark bar on NTP when Show Bookmarks Bar option is turned off. Maybe they wants options like Always Show Bookmarks Bar on NTP.
@rebron WDYT?

@rebron
Copy link
Collaborator

rebron commented Jun 10, 2019

@simonhong This is behavior I believe we should support and @petemill wants as well. I'll file a separate issue for it. We'll need to figure out how to display the pref for it.

@bsclifton
Copy link
Member

@JoshuaCarter we got a new issue tracking that feature request (#4782 - thanks, @rebron!) in case you wanted to subscribe for updates

We'll just need to find a place to land this proposed setting as I believe the default behavior we want for users would be to hide on new tab page (users who want to see it would adjust the setting).

@btlechowski
Copy link

btlechowski commented Jul 24, 2019

Verification passed on

Brave 0.68.109 Chromium: 76.0.3809.62 (Official Build) dev (64-bit)
Revision 7b77856b3aa34d72f246d12340fc1ded8b2c0e83-refs/branch-heads/3809@{#798}
OS Ubuntu 18.04 LTS

Verified test plan from brave/brave-core#2563
Currently bookmark bar visibility is handled by Show bookmarks bar toggle
The bookmark bar is not shown on new tab till Show bookmarks bar is switched to on.

Checked the Show bookmarks bar toggle in settings and hamburger menu.

Verified passed with

Brave 0.68.113 Chromium: 76.0.3809.62 (Official Build) beta (64-bit)
Revision 7b77856b3aa34d72f246d12340fc1ded8b2c0e83-refs/branch-heads/3809@{#798}
OS Mac OS X
  • Verified Show bookmarks bar toggle controls whether bookmarks bar is shown on new tab page (on) or not (off).
  • Verified Show bookmarks bar setting from hamburger menu and brave://settings.
  • Verification passed on
Brave 0.68.119 Chromium: 76.0.3809.87 (Official Build) beta (64-bit)
Revision 111fe1e15d5ced26080a7dc239bcfe70f6c49aad-refs/branch-heads/3809@{#967}
OS Windows 10 OS Version 1803 (Build 17134.523)
  • Verified Show bookmarks bar toggle controls whether bookmarks bar is shown on new tab page (on) or not (off).
  • Verified Show bookmarks bar setting from hamburger menu and brave://settings.

@mazupicua
Copy link

Verification passed on

Brave 0.68.109 Chromium: 76.0.3809.62 (Official Build) dev (64-bit)
Revision 7b77856b3aa34d72f246d12340fc1ded8b2c0e83-refs/branch-heads/3809@{#798}
OS Ubuntu 18.04 LTS
Verified test plan from brave/brave-core#2563
Currently bookmark bar visibility is handled by Show bookmarks bar toggle
The bookmark bar is not shown on new tab till Show bookmarks bar is switched to on.

Checked the Show bookmarks bar toggle in settings and hamburger menu.

Any idea when this is coming to windows?

@simonhong
Copy link
Member

simonhong commented Jul 26, 2019

Verification passed on
Brave 0.68.109 Chromium: 76.0.3809.62 (Official Build) dev (64-bit)
Revision 7b77856b3aa34d72f246d12340fc1ded8b2c0e83-refs/branch-heads/3809@{#798}
OS Ubuntu 18.04 LTS
Verified test plan from brave/brave-core#2563
Currently bookmark bar visibility is handled by Show bookmarks bar toggle
The bookmark bar is not shown on new tab till Show bookmarks bar is switched to on.
Checked the Show bookmarks bar toggle in settings and hamburger menu.

Any idea when this is coming to windows?

@mazupicua Currently, this feature is in dev channel(0.68.x) on Windows also.
It would be in stable at August 20, 2019. You can check our release schedule here - https://github.com/brave/brave-browser/wiki/Brave-Release-Schedule

@cuzer
Copy link

cuzer commented Aug 4, 2019

+1

@Curuphan
Copy link

Curuphan commented Aug 6, 2019

Oh. So the bookmarks bar disappeard because it was asked for. And i didn't know where did it gone.... Do i understand correctly if it will be switcheable on new tab? I liked the way it worked. When i opened a new tab, i could load a page from the bookmarks bar (especially from the bookmarks button on the right of the bookmarks bar) , but i don't need that bar on other tabs. But now, i can turn it on only on all tabs. It's nonsense.

@rebron
Copy link
Collaborator

rebron commented Aug 6, 2019

@Curuphan the fix for that is here #4782.

There's a setting to always show bookmarks bar and the fact that setting didn't work on the new tab page was the problem. People who don't want to use bookmarks at all don't want to see the bookmarks bar anywhere and we should honor that setting which we did.

@JoshuaCarter
Copy link

@rebron That's fine, but many of us don't want it on all the time, yet still want easy access to it, which is what a 'new tab only bookmarks bar' gives. Also this is how it's works for me for years on Chrome anyway so I took it for granted that this was the intention. It needs to be 3 options: [on, off, new-tab]. This might be a non-issue if I could find a half-decent new-tab-bookmarks-bar extension, but I can't (I last checked around the time of my last comment on this issue).

@rebron
Copy link
Collaborator

rebron commented Aug 6, 2019

@JoshuaCarter See here please: brave/brave-core#2869
It provides a pref for the original behavior.

@JoshuaCarter
Copy link

@rebron @simonhong Outstanding, many thanks.

@bigt2000
Copy link

Are there plans to bring 3 options as mentioned by Joshua? I preferred to only see the bookmarks bar on a new tab and agree that giving the option to pick which one you want is better than omitting an option.

@WeirdWhirl
Copy link

So this is why my NTP bookmark bar has disappeared. This sucks, I use that thing constantly.
I'm downgrading to the previous version until the NTP option is implemented.
I'm starting to feel old. I keep getting pissed off that often used software features keep getting killed without any obvious notice.

@adamreisnz
Copy link

This was a silly issue to raise. Now we can't access our bookmark bar in a new tab anymore without being forced to see the bar for every... single... tab.

Someone please hit undo.

@simonhong
Copy link
Member

@adamreisnz Sorry for your inconvenience.
We fixed (brave/brave-core#2869) and I assume that it will be uplifted to beta(0.69.x).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment