Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Desktop] Brave Today should not fetch data until interacted with #13059

Closed
petemill opened this issue Dec 5, 2020 · 1 comment · Fixed by brave/brave-core#7353
Closed

[Desktop] Brave Today should not fetch data until interacted with #13059

petemill opened this issue Dec 5, 2020 · 1 comment · Fixed by brave/brave-core#7353
Assignees
Labels
feature/brave-news formerly brave-today OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-Win64 QA/Yes release-notes/exclude

Comments

@petemill
Copy link
Member

petemill commented Dec 5, 2020

Whilst Brave Today requests are completely anonymous, we want to make sure we're not making any requests unnecessarily, especially without user interaction. It would be ideal to only request Brave Today data once the user interacts with the feature, either by scrolling down to view the feed or customizing settings.

Test Plan

Since a request has been removed, we mainly need to check that the feed is still correctly fetched and updated:

  • Content is retrieved on a fresh profile
  • When modifying publishers list (via toggling off and on), the feed still updates to exclude or include the new publishers.

However, in order to verify that there is no fetch before the feature is interacted with AFAIK we will need a third party app (e.g. Little Snitch) to verify no connection is made on startup. Once the browser is started up, we can use the Brave extension DevTools (via chrome://inspect#extensions) to verify that the feed is not fetched when a NTP is opened, and only fetched when either:

  • Scrolling down to open the Brave Today feed (and a loading indicator is shown whilst waiting for the first time)
  • Opening the customize dialog and switching to the Brave Today tab
@petemill petemill self-assigned this Dec 5, 2020
@rebron rebron added the feature/brave-news formerly brave-today label Dec 7, 2020
@petemill petemill added this to the 1.20.x - Nightly milestone Dec 8, 2020
@rebron rebron added the priority/P2 A bad problem. We might uplift this to the next planned release. label Dec 8, 2020
@btlechowski
Copy link

Verification passed on

Brave 1.18.70 Chromium: 87.0.4280.101 (Official Build) (64-bit)
Revision 9407c80213cda69c2b7abcb4fa8e3f74488f4956-refs/branch-heads/4280@{#1807}
OS Windows 7 Service Pack 1 (Build 7601.24544)

Verified test plan from the description
Verified the content is fetched after scrolling down
image
Verified the feed still updates to exclude or include the new publishers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/brave-news formerly brave-today OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-Win64 QA/Yes release-notes/exclude
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants