Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update lifeguard dependency of adblock-rust #12820

Closed
antonok-edm opened this issue Nov 21, 2020 · 0 comments · Fixed by brave/brave-core#7219
Closed

Update lifeguard dependency of adblock-rust #12820

antonok-edm opened this issue Nov 21, 2020 · 0 comments · Fixed by brave/brave-core#7219
Assignees
@antonok-edm
Labels
build dependencies Pull requests that update a dependency file dev-concern OS/Desktop priority/P1 A very extremely bad problem. We might push a hotfix for it. QA/No release-notes/exclude
Milestone
1.18.x - Release #3

Comments

@antonok-edm
Copy link
Collaborator

antonok-edm commented Nov 21, 2020 •
edited
Loading

We'd like to get native arm64 macOS builds working ASAP (#12819). Doing so requires using the Nightly version of the Rust compiler. However, starting in 1.49.0 there is a new runtime check for memory reserved by mem::uninitialized(), which is used by lifeguard.

Tracking issue in lifeguard: zslayton/lifeguard#25

Tracking issue in adblock-rust: brave/adblock-rust#147

There is a proposed fix included in this lifeguard PR: zslayton/lifeguard#25
@antonok-edm antonok-edm added priority/P1 A very extremely bad problem. We might push a hotfix for it. dev-concern build dependencies Pull requests that update a dependency file OS/Desktop labels Nov 21, 2020
@antonok-edm antonok-edm self-assigned this Nov 21, 2020
@antonok-edm antonok-edm mentioned this issue Nov 21, 2020
Merged
23 tasks
@antonok-edm antonok-edm added this to the 1.19.x - Nightly milestone Nov 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@antonok-edm antonok-edm

Labels
build dependencies Pull requests that update a dependency file dev-concern OS/Desktop priority/P1 A very extremely bad problem. We might push a hotfix for it. QA/No release-notes/exclude
Projects
None yet
Milestone
1.18.x - Release #3
Development

Successfully merging a pull request may close this issue.

Update lifeguard dependency to 0.6.1 brave/brave-core
2 participants
@kjozwiak @antonok-edm