Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Brave Today publishers should be easily disabled #12608

Closed
petemill opened this issue Nov 10, 2020 · 1 comment · Fixed by brave/brave-core#7104
Closed

Brave Today publishers should be easily disabled #12608

petemill opened this issue Nov 10, 2020 · 1 comment · Fixed by brave/brave-core#7104

Comments

@petemill
Copy link
Member

petemill commented Nov 10, 2020

Design requirement to be able to click on any card's publisher and have a menu popup to disable that publisher.

image

Test plan

  1. Scroll to Brave Today
  2. Any Publisher name (except on a category list card) should be able to be hovered to present a button
  3. Clicking the button should open a popup with 1 entry labeled "Disable content from [publisher name]"
    3.a. Clicking that popup menu entry should close the popup.
    3.b. Pressing escape should close the popup
    3.c. Clicking outside of the popup should close the popup
  4. When clicking the popup menu entry, after a brief moment, the "Load New Content" blue "pill" button should appear at the top of the Viewport. Clicking should refresh the feed with the publisher's content removed.
@petemill petemill self-assigned this Nov 10, 2020
@petemill petemill added this to the 1.18.x - Nightly milestone Nov 11, 2020
@rebron rebron changed the title [Desktop] Brave Today publishers should be easily disabled Brave Today publishers should be easily disabled Dec 7, 2020
@btlechowski
Copy link

Verification passed on

Brave 1.18.70 Chromium: 87.0.4280.101 (Official Build) (64-bit)
Revision 9407c80213cda69c2b7abcb4fa8e3f74488f4956-refs/branch-heads/4280@{#1807}
OS Windows 7 Service Pack 1 (Build 7601.24544)

Verified test plan from the description
Verified clicking on publisher button shown Disable Content Menu
image

Verified clicking that popup menu entry closes the popup.
Verified pressing escape closes the popup
Verified clicking outside of the popup closes the popup
Verified the content from given publisher is disabled
Verified clicking the popup menu entry, after a brief moment, the "Load New Content" blue "pill" button appears at the top of the Viewport
image
Verified clicking refreshes the feed with the publisher's content removed.

Logged #13112

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment