Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement earn and give onboarding flow #12138

Closed
NejcZdovc opened this issue Oct 14, 2020 · 11 comments · Fixed by brave/brave-core#7050
Closed

Implement earn and give onboarding flow #12138

NejcZdovc opened this issue Oct 14, 2020 · 11 comments · Fixed by brave/brave-core#7050

Comments

@NejcZdovc
Copy link
Contributor

No description provided.

@NejcZdovc NejcZdovc changed the title Implement earn&give onboarding [Desktop] Implement earn&give onboarding Oct 14, 2020
@zenparsing
Copy link

Rewards onboarding tour will be implemented in #12459

@zenparsing
Copy link

Clarifying questions:

  • What rule determines when the onboarding modal is displayed on the panel or on the rewards page?
    • Both Ads and AC disabled?
    • Is it tied to the first panel/page visit?
    • Do we need to store something in preferences to indicate that they've dismissed the modal?
  • What rule determines when the onboarding form is displayed on the tip dialog?
    • Both Ads and AC disabled?
  • What does clicking the "Start using Brave Rewards" button do?
    • Enable both AC and Ads?

@NejcZdovc
Copy link
Contributor Author

NejcZdovc commented Nov 4, 2020

What rule determines when the onboarding modal is displayed on the panel or on the rewards page?

FIrst load of the panel/page. When user click on start or dismiss it we should not show it again. If user has already ads on we don't show this onboarding. For example if user sees this dialog in the panel and click dismiss or start when the go to tipping banner it should not be shown again.

What does clicking the "Start using Brave Rewards" button do?

It enables ads and ac

@zenparsing
Copy link

@NejcZdovc It seems like we'll need a pref to store whether the user has seen and interacted with the onboarding modal, unless you think there's a better way?

@NejcZdovc
Copy link
Contributor Author

perf should work yes

@bbondy
Copy link
Member

bbondy commented Nov 10, 2020

Could you add release/blocking if this is blocking the release? Otherwise remove from the milestone. Thank you.

@NejcZdovc
Copy link
Contributor Author

label added

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Dec 3, 2020

Verification passed on


Brave | 1.18.68 Chromium: 87.0.4280.67 (Official Build) dev (64-bit)
-- | --
Revision | 0e5d92df40086cf0050c00f87b11da1b14580930-refs/branch-heads/4280@{#1441}
OS | Windows 10 OS Version 2004 (Build 19041.630)

Rewards Panel (dismissing case)
  1. Click on Rewards Badge displays "Earn Tokens & Give Back" modal
    image

  2. Click on the "Terms of Service" link in the Rewards Badge navigates to https://basicattentiontoken.org/user-terms-of-service/
    image

  3. Click on the "Privacy Policy" link in the Rewards Badge navigates to https://brave.com/privacy/browser/#rewards
    image

  4. Verified that click on X closes the rewards onboarding modal
    image
    image

  5. Verified that rewards onboarding modal is shown in brave://rewards settings page when rewards onboarding is dismissed in BR panel
    image

  6. Verified that Ads and Auto-Contribute switches are in OFF state in brave://rewards settings page

Rewards panel (opting-in case)
  • Verified that rewards onboarding isn't displayed on the BR panel once Rewards is enabled from BR panel by clicking on the "Start using Brave Rewards" button.
    image
    image

  • Verified that Ads and Auto- Contribute switches are in ON state when rewards is enabled via BR panel
    image

Inline tipping (dismissing case)
  • Clicked on Rewards badge in BR panel and ensured that rewards extension is running
    image

  • Verified that inline tipping banner is displayed with rewards onboarding modal when inline tipping button is clicked in https://twitter.com/bravelaurenwags
    image

  • Verified that click on the "Terms of Service" link opens up https://basicattentiontoken.org/user-terms-of-service/ in a new tab
    image

  • Verified that click on the "Privacy Policy" link opens up https://brave.com/privacy/browser/#rewards in a new tab
    image

  • Verified that Tipping options are presented when the "Maybe Later" option is clicked in the tipping banner
    image

  • Verified that onboarding modal is presented to the user upon clicking on BR panel

  • Verified that Ads and Auto-Contribute switches are in OFF state in brave://rewards when onboarding is dismissed via BR panel

  • Verified that onboarding is shown again in brave://rewards settings page when onboarding is dismissed via BR panel

Inline tipping (opting-in case)
  • Clicked on Rewards badge in BR panel and ensured that rewards extension is running
    image

  • Verified that inline tipping banner is displayed with rewards onboarding modal when inline tipping button is clicked in https://twitter.com/bravelaurenwags
    image

  • Verified that tipping options are presented to the user after clicking on Start using Brave Rewards
    image

  • Clicked on BR panel and ensured that rewards onboarding Start using Brave Rewards isn't displayed in BR panel
    image

  • Verified that Ads and Auto-Contribute switches are in ON state in brave://rewards

Rewards page (dismissing case)
  1. Verified that onboarding modal is shown in a clean profile when brave://rewards is opened
    image

  2. Click on the "Terms of Service" link in the Rewards Badge navigates to https://basicattentiontoken.org/user-terms-of-service/
    image

  3. Click on the "Privacy Policy" link in the Rewards Badge navigates to https://brave.com/privacy/browser/#rewards
    image

  4. Verified that click on X closes the rewards onboarding modal
    image

  5. Clicked on BR panel and ensured rewards onboarding modal is shown
    image

Rewards page (opting-in case)
  • Verified that Ads and Auto-Contribute switches are ON when the Start using Brave Rewards button is clicked in brave://rewards page
    image
    image

  • Verified that onboarding modal is not shown upon clicking on BR panel
    image

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Dec 3, 2020

@zenparsing Test plan needs to update for the case "Inline tipping (dismissing case)" and "Rewards page (dismissing case)"

Open the rewards panel.
Verify that the onboarding modal is not displayed.

In the above cases, the onboarding modal should be displayed upon clicking on the BR panel, as rewards is not opt-in. Correct me if I am wrong.

@zenparsing
Copy link

@GeetaSarvadnya Thanks for pointing this out - the behavior was changed slightly in a subsequent PR (brave/brave-core#7135). I'll fix the test plan.

@GeetaSarvadnya
Copy link

@zenparsing Awesome!!!. Thanks for the quick response.

@rebron rebron changed the title [Desktop] Implement earn&give onboarding [Desktop] Implement earn and give onboarding Dec 7, 2020
@rebron rebron changed the title [Desktop] Implement earn and give onboarding Implement earn and give onboarding flow Dec 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment