Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Canvas FP values should be different when switching between standard and strict #12106

Closed
LaurenWags opened this issue Oct 13, 2020 · 3 comments

Comments

@LaurenWags
Copy link
Member

Description

Per discussion with @pes10k, if you change your FP shield setting from standard to strict, the Canvas FP values should not be the same between the two shield selections.

related issues: #9186 (Canvas FP farbling issue) and #12099 (Canvas Worker farbling issue)

Steps to Reproduce

  1. Clean profile
  2. Visit https://dev-pages.bravesoftware.com/farbling.html and/or https://dev-pages.brave.software/farbling.html
  3. Note shield setting for FP (most likely standard)
  4. Generate Fingerprints on the sites
  5. Take a screenshot to note values for Canvas row
  6. Change shield FP setting to strict for sites
  7. Generate Fingerprints on the sites again

Actual result:

Look at Canvas row - values are the same for both FP shield settings
1.16.x FP = standard
1 16 x standard FP Canvas2

1.16.x FP = strict
1 16 x strict FP Canvas2

Expected result:

Canvas row values should be different when choosing the other (standard or strict) FP selection

Reproduces how often:

easily

Desktop Brave version:

Brave 1.16.58 Chromium: 86.0.4240.75 (Official Build) dev (x86_64)
Revision c69c33933bfc72a159aceb4aeca939eb0087416c-refs/branch-heads/4240@{#1149}
OS macOS Version 10.14.6 (Build 18G3020)

Android Device details:

  • Install type (ARM, x86):
  • Device type (Phone, Tablet, Phablet):
  • Android version:

Version/Channel Information:

  • Can you reproduce this issue with the current release? yes 1.15.x
  • Can you reproduce this issue with the beta channel? yes 1.16.x
  • Can you reproduce this issue with the nightly channel? yes 1.17.x

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

cc @pes10k @rebron

@LaurenWags LaurenWags added feature/shields/fingerprint The fingerprinting (aka: "device recognition") protection provided in Shields QA/Yes OS/Android Fixes related to Android browser functionality OS/Desktop labels Oct 13, 2020
@pes10k
Copy link
Contributor

pes10k commented Apr 2, 2021

Hi @LaurenWags are you still seeing this? I believe it should be fixed now. Can you verify when you have a chance?

@LaurenWags
Copy link
Member Author

LaurenWags commented Apr 5, 2021

@pes10k appears fixed on latest Nightly 🎉

Brave | 1.24.46 Chromium: 90.0.4430.41 (Official Build) nightly (x86_64)
-- | --
Revision | e9c92b1eaca8487e212f3f6bc081fdb6d4863759-refs/branch-heads/4430@{#723}
OS | macOS Version 10.15.7 (Build 19H524)

Confirmed that Canvas FP values differ between the two pages once Fingerprints have been generated (columns 1 & 2 in table below).
Confirmed that Canvas FP values differ between standard/strict settings for the same page (rows 1 & 2 in table below).

FP = Standard FP = Strict
bravesoftware - STD bravesoftware - strict
brave software - STD brave software - strict

Verification passed on

Brave 1.24.66 Chromium: 90.0.4430.72 (Official Build) beta (64-bit)
Revision b6172ef8d07ef486489a4b11b66b2eaeed50d132-refs/branch-heads/4430@{#1233}
OS Ubuntu 18.04 LTS

Verified test plan from the description

Confirmed that Canvas FP values differ between the two pages once Fingerprints have been generated (columns 1 & 2 in table below).
Confirmed that Canvas FP values differ between standard/strict settings for the same page (rows 1 & 2 in table below).

FP = Standard FP = Strict
image image
image image

Verification passed on

Brave | 1.24.72 Chromium: 90.0.4430.72 (Official Build) dev (64-bit)
-- | --
Revision | b6172ef8d07ef486489a4b11b66b2eaeed50d132-refs/branch-heads/4430@{#1233}
OS | Windows 10 OS Version 2004 (Build 19041.928)

Verified test plan from the description

Confirmed that Canvas FP values differ between the two pages once Fingerprints have been generated (columns 1 & 2 in table below).
Confirmed that Canvas FP values differ between standard/strict settings for the same page (rows 1 & 2 in table below).

FP = Standard FP = Strict
image image
image image

Verified PASSED on 1.24.76, Chromium 90.0.4430.85, Android 9, Google Pixel XL, arm64.

Verified test plan from the description

Confirmed that the Canvas FP values differ between standard/strict settings for the same page

standard strict
standard strict

@srirambv
Copy link
Contributor

Verification passed on Samsung Tab A with Android 10 running 1.24.81 x64 build

  • Verified Canvas FP value is different on both pages for pages for strict/standard settings
image image
image image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants