Brave Ads crash when updating catalog issuers

[tmancey]

https://brave.sp.backtrace.io/p/brave/debug?time=all&filters=(_deleted%3D0%2C(callstack%2Cregex%2C%22(BatAds%7CAdsService%7CAdsImpl%7CConfirmationsImpl)%22)%2C(ver%2Cregex%2C%22(86.1%7C85.1%7C84.1%7C83.1)%22))&fingerprint=0000000000000000000000000000000000000000000000000000000000000202

[00] ads::ConfirmationsState::ToJson
[01] ads::Confirmations::Save
[02] ads::Confirmations::SetCatalogIssuers
[03] ads::GetCatalog::OnDownloaded
[04] bat_ads::OnUrlRequest(std::__1::function<void
[05] bat_ads::mojom::BatAdsClient_UrlRequest_ForwardToCallback::Accept
[06] mojo::InterfaceEndpointClient::HandleIncomingMessageThunk::Accept
[07] mojo::internal::MultiplexRouter::ProcessIncomingMessage
[08] mojo::internal::MultiplexRouter::Accept
[09] mojo::Connector::ReadAllAvailableMessages
[10] mojo::SimpleWatcher::OnHandleReady
[11] base::TaskAnnotator::RunTask
[12] base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoWork
[13] base::MessagePumpDefault::Run
[14] base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::Run
[15] base::RunLoop::Run
[16] content::UtilityMain
[17] content::ContentMainRunnerImpl::Run
[18] service_manager::Main
[19] content::ContentMain
[20] ChromeMain

[tmancey]

@jsecretan this issue occurs if a mismatched version of the catalog is downloaded which is likely only going to occur if the catalog is rewritten using a proxy

[btlechowski]

Verification passed on

Brave	1.17.68 Chromium: 87.0.4280.49 (Official Build) (64-bit)
Revision	f77f85899646b42a1d3c8ff36794e00becab9171-refs/branch-heads/4280@{#1115}
OS	Windows 7 Service Pack 1 (Build 7601.24544)

Verified test plan from brave/brave-core#6816
Steps:

1. Clean profile on staging
2. Enable rewards on staging
3. Wait for the rewards initialization (catalog v5 is downloaded)
4. Close Brave
5. Overwrite the catalog using v4 catalog: ptr_1_untargeted_ads_2campaign_1creativeSet_1ad.txt
6. Run Brave

Verified no crash
Verified unable to parse the catalog

[5808:13220:1116/055324.846:VERBOSE1:get_catalog.cc(83)] Successfully downloaded catalog
[5808:13220:1116/055324.846:VERBOSE1:get_catalog.cc(112)] Parsing catalog
[5808:13220:1116/055324.847:INFO:get_catalog.cc(116)] Failed to load catalog

Verified retry is scheduled:

Retry downloading catalog in 0 hours, 2 minutes, 27 seconds at 5:55 AM

Verified that after turning off rewrite, the catalog was parsed properly:

[5808:13220:1116/055552.735:VERBOSE1:get_catalog.cc(83)] Successfully downloaded catalog
[5808:13220:1116/055552.735:VERBOSE1:get_catalog.cc(112)] Parsing catalog
[5808:13220:1116/055552.735:VERBOSE1:get_catalog.cc(130)] Generating bundle
[5808:13220:1116/055552.736:VERBOSE3:bundle.cc(466)] Successfully saved creative ad notifications state
[5808:13220:1116/055552.736:VERBOSE3:bundle.cc(476)] Successfully saved creative new tab page ads state
[5808:13220:1116/055552.736:VERBOSE3:bundle.cc(496)] Successfully saved ad conversions state
[5808:13220:1116/055552.736:VERBOSE1:get_catalog.cc(138)] Successfully generated bundle
[5808:13220:1116/055552.736:VERBOSE1:confirmations.cc(50)] SetCatalogIssuers:

---

Verified passed with

Brave	1.17.69 Chromium: 87.0.4280.60 (Official Build) (x86_64)
Revision	12697cfeb273d7de95cf9b18350d2c457f58224c-refs/branch-heads/4280@{#1352}
OS	macOS Version 10.14.6 (Build 18G6042)

Verified test plan from brave/brave-core#6816
Steps:

1. Clean profile on staging
2. Enable rewards on staging
3. Wait for the rewards initialization (catalog v5 is downloaded)
4. Close Brave
5. Overwrite the catalog using v4 catalog: ptr_1_untargeted_ads_2campaign_1creativeSet_1ad.txt
6. Run Brave

No crash observed or listed in brave://crashes

Verified unable to parse the catalog

[10432:775:1117/075723.875926:VERBOSE1:get_catalog.cc(83)] Successfully downloaded catalog
[10432:775:1117/075723.875974:VERBOSE1:get_catalog.cc(112)] Parsing catalog
[10432:775:1117/075723.876763:INFO:get_catalog.cc(116)] Failed to load catalog

Verified retry is scheduled:

[10432:775:1117/075723.877195:VERBOSE1:get_catalog.cc(168)] Retry downloading catalog in 0 hours, 1 minute, 19 seconds at 7:58 AM

Verified that after turning off rewrite, the catalog was parsed properly:

[10432:775:1117/080032.938535:VERBOSE1:get_catalog.cc(83)] Successfully downloaded catalog
[10432:775:1117/080032.938569:VERBOSE1:get_catalog.cc(112)] Parsing catalog
[10432:775:1117/080032.941034:VERBOSE1:get_catalog.cc(130)] Generating bundle
[10432:775:1117/080032.941077:VERBOSE1:bundle.cc(356)] creative set id 486d1bbe-e460-474e-ac26-d554cb1a21d4 has no entries
[10432:775:1117/080032.941212:VERBOSE1:bundle.cc(356)] creative set id 7be431a0-c6e4-4ca6-bcac-672e77294b7d has no entries
[10432:775:1117/080032.941280:VERBOSE1:bundle.cc(356)] creative set id 175bc3ca-50f0-4749-bfc8-c7ff7482de0f has no entries
[10432:775:1117/080032.941741:VERBOSE1:bundle.cc(197)] Creative set id afe51106-2c27-4aeb-87a6-cbf836f6da0b does not support macos
[10432:775:1117/080032.941786:VERBOSE1:bundle.cc(356)] creative set id afe51106-2c27-4aeb-87a6-cbf836f6da0b has no entries
[10432:775:1117/080032.945341:VERBOSE1:get_catalog.cc(138)] Successfully generated bundle
[10432:775:1117/080032.945455:VERBOSE1:confirmations.cc(50)] SetCatalogIssuers:

Confirmed able to view an ad once catalog was parsed properly.

---